Use runtime CARGO_CFG_TARGET_ARCH in build-script #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
option_env retrieves the CARGO_CFG_TARGET_ARCH at compile-time, which is not correct for the usage here. Instead, we should retrieve the variable using env::var at runtime in the build-script.
d-e-s-o
approved these changes
Oct 7, 2024
d-e-s-o
added a commit
to d-e-s-o/libbpf-rs
that referenced
this pull request
Oct 7, 2024
Add a CHANGELOG entry for pull request libbpf#959, which fixed the CARGO_CFG_TARGET_ARCH environment variable query from a build script in a cross-compilation context. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
added a commit
that referenced
this pull request
Oct 7, 2024
Add a CHANGELOG entry for pull request #959, which fixed the CARGO_CFG_TARGET_ARCH environment variable query from a build script in a cross-compilation context. Signed-off-by: Daniel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option_env retrieves the CARGO_CFG_TARGET_ARCH at compile-time, which is not correct for the usage here. Instead, we should retrieve the variable using env::var at runtime in the build-script.
Fix https://github.com/kxxt/tracexec/actions/runs/11213953908/job/31168026074?pr=41
See also #958