Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining NOMINMAX for windows to prevent std::{min,max} issues #1003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Defining NOMINMAX for windows to prevent std::{min,max} issues #1003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0beb518
Defining NOMINMAX for windows to prevent std::{min,max} issues
COM8 Dec 28, 2023
4d99fca
Defining NOMINMAX for all in cpr
COM8 Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ add_library(cpr

add_library(cpr::cpr ALIAS cpr)

# Add the NOMINMAX macro for windows to curl to prevent issues with std::min and std::max down the line.
# Ref: https://github.com/libcpr/cpr/issues/957
if(WIN32)
target_compile_definitions(cpr PUBLIC NOMINMAX)
endif()

target_link_libraries(cpr PUBLIC CURL::libcurl) # todo should be private, but first dependencies in ssl_options need to be removed

# Fix missing OpenSSL includes for Windows since in 'ssl_ctx.cpp' we include OpenSSL directly
Expand Down
Loading