fix: let bad-host-tests pass when there is DNS error redirection #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for bad hosts (issue libcpr#1165)
COM8
approved these changes
Jan 25, 2025
COM8
added a commit
that referenced
this pull request
Feb 17, 2025
fix: let bad-host-tests pass when there is DNS error redirection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
In bad host tests, when the DNS server is configured with error redirection, it may return a fake IP such as
127.0.0.2instead of an NXDOMAIN response, which causes the tests fail. #1165Solution
Add a "OR" condition to those tests, both
CURLE_COULDNT_RESOLVE_HOST (6)andCURLE_COULDNT_CONNECT (7)should pass.