Rr/add cmake build and provide handle to platform dependent function #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, please take a look at my suggestion for improving the library
Providing
ds1307_handle_t
is necessary for things like this:This will allow you to get, for example, an i2c handler from the structure.
The changes do not cover your entire repository, they only provide minimal functionality for the driver itself. If you are interested, I can continue moving in this direction