This repository has been archived by the owner on May 14, 2020. It is now read-only.
Allow empty response bodies #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
commented
Dec 12, 2019
This was referenced Dec 12, 2019
giorgiosironi
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koa sets the body of a response as the status message if it hasn't been explicitly set and it's not a regular empty response (eg
204 No Content). This prevents it from happening.(This is expected behaviour of Koa, but not of this app, so I'm calling it a bug.)
Extracted from #104.