Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Add operation types #128

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Conversation

thewilkybarkid
Copy link
Contributor

Adds Schema.org operation types to the API.

Extracted from #104.

@thewilkybarkid thewilkybarkid added the 🆕 Feature A new feature label Dec 19, 2019
@thewilkybarkid thewilkybarkid requested a review from a team as a code owner December 19, 2019 10:45
@@ -21,7 +21,7 @@ export default (): AppMiddleware => (
'@type': hydra.Class,
[hydra.title]: { '@value': 'API entry point', '@language': 'en' },
[hydra.supportedOperation]: {
'@type': hydra.Operation,
'@type': [hydra.Operation, schema.ViewAction],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if ViewAction is the most appropriate. DownloadAction? ReceiveAction?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though thinking maybe there's really no need to include GET operations, as Hydra resources have to be dereferenceable?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ReadAction?

@thewilkybarkid thewilkybarkid merged commit a73e8bb into libero:master Dec 19, 2019
@thewilkybarkid thewilkybarkid deleted the operation-name branch December 19, 2019 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 Feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants