Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add UART to stm32f411 #85

Merged
merged 4 commits into from
Jan 14, 2025
Merged

✨ Add UART to stm32f411 #85

merged 4 commits into from
Jan 14, 2025

Conversation

FluffyFTW
Copy link
Contributor

  • Add UART to stm32f411
  • Fixed frequency() for the clock tree

@FluffyFTW FluffyFTW requested a review from kammce January 7, 2025 22:07
@FluffyFTW FluffyFTW force-pushed the stm32f411_dma_config branch 8 times, most recently from 556190c to 8021c9c Compare January 12, 2025 03:55
@FluffyFTW
✨ Add UART to stm32f411
4f5a90f 
- Add UART to stm32f411
- Fixed frequency() for the clock tree
@FluffyFTW FluffyFTW force-pushed the stm32f411_dma_config branch from 8021c9c to 4f5a90f Compare January 12, 2025 03:57
kammce
kammce requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@kammce kammce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @FluffyFTW ! Love the work. I've got a few things to fix up.

include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
demos/applications/uart.cpp Show resolved Hide resolved
src/stm32_generic/uart.cpp Show resolved Hide resolved
src/stm32_generic/uart.cpp Outdated Show resolved Hide resolved
src/stm32f411/dma.cpp Outdated Show resolved Hide resolved
src/stm32f411/uart.cpp Outdated Show resolved Hide resolved
src/stm32f411/uart.cpp Outdated Show resolved Hide resolved
src/stm32f411/uart.cpp Outdated Show resolved Hide resolved
src/stm32f411/uart.cpp Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/uart.hpp Outdated Show resolved Hide resolved
@FluffyFTW FluffyFTW force-pushed the stm32f411_dma_config branch from 7d282ba to eae654b Compare January 14, 2025 19:34
@FluffyFTW FluffyFTW force-pushed the stm32f411_dma_config branch from eae654b to e775746 Compare January 14, 2025 19:37
kammce
kammce requested changes Jan 14, 2025
View reviewed changes
include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/dma.hpp Show resolved Hide resolved
kammce
kammce requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@kammce kammce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! I have a few nitpicks but after that we should be able to submit this.

include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/dma.hpp Outdated Show resolved Hide resolved
include/libhal-arm-mcu/stm32f411/dma.hpp Show resolved Hide resolved
@FluffyFTW FluffyFTW merged commit 3932397 into libhal:main Jan 14, 2025
16 checks passed
@FluffyFTW FluffyFTW deleted the stm32f411_dma_config branch January 14, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kammce kammce kammce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FluffyFTW @kammce