Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liblouis stable version from 3.26.0 to 3.27.0 version #99

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

hammera
Copy link
Contributor

@hammera hammera commented Sep 12, 2023

Hi Boys,

As it is usual, I updated after Liblouis 3.27.0 release publication the Liblouis UTDML used stable version from 3.26.0 version to 3.27.0 version.
The first commit affected files:

  • Dockerfile.win32,
  • Dockerfile.win64,
  • .github/workflows/main.yml,
  • .github/workflows/sanitizer.yml

The second commit resolves 25 failed voluve test files failures related issue after 3.27.0 version migration, the diff output is showed @bertfrees in Liblouis issue #1434.
The second commit fixes Liblouis issue #1434

My machine make distwin command ran succesfull.

Attila

Affected files: Dockerfile.win32, Dockerfile.win64, .github/workflows/main.yml,
.github/workflows/sanitizer.yml

Signed-off-by: Attila Hammer <[email protected]>
The 25 voluve tests failed if Liblouis Utdml uses Liblouis master branch
and 3.27.0 version.
Fixed [issue #1434 in Liblouis](liblouis/liblouis#1434)

Signed-off-by: Attila Hammer <[email protected]>
@hammera
Copy link
Contributor Author

hammera commented Sep 12, 2023

Oh...
The sanitizer triggerer tests. :-):-)
I Always forgot disable following new nemeth_MathCAT tests with always triggering address sanitizer:

  • nemeth_MathCAT/identity_matrix_126.test
  • nemeth_MathCAT/table_entry_after_sup_79_c_4.test

Just a moment please, I resolve this forgotted change. :-):-)

Attila

Affected test files:
nemeth_MathCAT/identity_matrix_126.test
nemeth_MathCAT/table_entry_after_sup_79_c_4.test

Signed-off-by: Attila Hammer <[email protected]>
@hammera hammera marked this pull request as ready for review September 12, 2023 16:48
@hammera
Copy link
Contributor Author

hammera commented Sep 12, 2023

Boys, final all checks are passed, this PR are review ready, perhaps a squash operation need before merge.
If this pull request can possibly get a higher priority, I can solve a problem similar to the second commit in my nemeth_mathml_improvements development branch after the merge.
If I comb the branches there, I only need to change the state of a single test in tests/Makefile.am my nemeth table improvements related feature branch, but first need migrate Liblouis version from 3.26.0 to 3.27.0 version before I doing this.

Thanks the cooperation, and congratulate the new 3.27.0 Liblouis release,

Attila

@hammera
Copy link
Contributor Author

hammera commented Oct 3, 2023

Boys, have possibility to review and merge this PR to I apply the required modifications with #96 pull request feature branch related (to fix a failing check with produce the old wiskunde table)?
After this PR is merged, estimated how many work require reviewing @NorbertMarkus doed nemeth table changes the #96 PR, before have chance happens the final merge into the master branch?
Very old time released Liblouis UTDML 2.11.0 ( if I remember correct in 2022. march when publicated Liblouis 3.21.0 release), we very would like offer the community the new changed and updated Nemeth tables a new Liblouis UTDML 2.12.0 release.
I didn't want to sound impatient, but we really want the improved math tables to be used by the international Braille community in the Liblouis UTDML package.
Since February 2023, Norbert has put a lot of work into the development, if I can help with anything that makes the review easier regarding pull request #96, I'd be happy to help.

Attila

@egli egli merged commit 1ff28ae into liblouis:master Oct 6, 2023
5 checks passed
@egli egli added this to the 2.12 milestone Oct 6, 2023
@bertfrees
Copy link
Member

@hammera I have reviewed #96 but still have some cleanup work to do before I can merge it. I will try to prioritize it.

@hammera
Copy link
Contributor Author

hammera commented Oct 9, 2023

Ok Bert, thanks the review.

If I have possibility to help the cleanup, drop please a suggestion message with #96 the comment box and I will doing the cleanup.
Me have more time after october 16, unfortunately, this week I have a futures job, which I have need to do before maximum on October 16th.

Attila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants