Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): revise translation & i18n keys #1925

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

3gf8jv4dv
Copy link
Contributor

With my best efforts, sincerity, and double-checking for grammar and text style, there may be errors.

And there may be some breaking changes involved, requiring careful review.

cc @keiko233 @greenhat616 @4o3F

@3gf8jv4dv
Copy link
Contributor Author

Umm... leave some more time to check.

@3gf8jv4dv 3gf8jv4dv marked this pull request as draft November 3, 2024 12:17
@greenhat616
Copy link
Collaborator

I have updated the main branch to fix the OOM issue. Please rebase on the latest main branch to fix the ci issue

Copy link
Collaborator

@greenhat616 greenhat616 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add #[serde(alias = "xx") to make compatiable with current version, or write a migration to migrate current config.

Ref: https://serde.rs/field-attrs.html#alias

Copy link
Collaborator

@greenhat616 greenhat616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3gf8jv4dv
Copy link
Contributor Author

@greenhat616 Thank you for reviewing. But I will keep the draft for a while to check if there are other mistakes in the translation.

@3gf8jv4dv 3gf8jv4dv changed the title chore(i18n): revise English translation & i18n keys chore(i18n): revise translation & i18n keys Nov 5, 2024
@3gf8jv4dv 3gf8jv4dv marked this pull request as ready for review November 5, 2024 13:42
@3gf8jv4dv
Copy link
Contributor Author

@greenhat616 ready.

@greenhat616 greenhat616 merged commit 8b89c10 into libnyanpasu:main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants