Skip to content

Commit

Permalink
more work on keyboard support
Browse files Browse the repository at this point in the history
  • Loading branch information
Andreas Monzner committed Jun 7, 2006
1 parent 4544237 commit fce04eb
Show file tree
Hide file tree
Showing 12 changed files with 173 additions and 58 deletions.
4 changes: 4 additions & 0 deletions data/keymap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@
<key id="KEY_ESC" mapto="cancel" flags="m" />
</map>

<map context="InputAsciiActions">
<key id="KEY_ASCII" mapto="gotAsciiCode" flags="mr" />
</map>

<map context="InputBoxActions">
<key id="KEY_LEFT" mapto="left" flags="mr" />
<key id="KEY_RIGHT" mapto="right" flags="mr" />
Expand Down
1 change: 1 addition & 0 deletions keyids.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@
"KEY_DEL_EOS": 449,
"KEY_INS_LINE": 450,
"KEY_DEL_LINE": 451,
"KEY_ASCII": 510,
"KEY_MAX": 511,
"BTN_0": 256,
"BTN_1": 257,
Expand Down
8 changes: 4 additions & 4 deletions lib/actions/action.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ struct call_entry
{
PyObject *m_fnc, *m_arg;
eWidget *m_widget;
void *m_widget_arg;
void *m_widget_arg, *m_widget_arg2;
call_entry(PyObject *fnc, PyObject *arg): m_fnc(fnc), m_arg(arg), m_widget(0), m_widget_arg(0) { }
call_entry(eWidget *widget, void *arg): m_fnc(0), m_arg(0), m_widget(widget), m_widget_arg(arg) { }
call_entry(eWidget *widget, void *arg, void *arg2): m_fnc(0), m_arg(0), m_widget(widget), m_widget_arg(arg), m_widget_arg2(arg2) { }
};

void eActionMap::keyPressed(int device, int key, int flags)
Expand Down Expand Up @@ -158,7 +158,7 @@ void eActionMap::keyPressed(int device, int key, int flags)
// (k->second.m_device == m_device) &&
(k->second.m_key == key) &&
(k->second.m_flags & (1<<flags)))
call_list.push_back(call_entry(i->second.m_widget, (void*)k->second.m_action));
call_list.push_back(call_entry(i->second.m_widget, (void*)i->second.m_id, (void*)k->second.m_action));
}
} else
{
Expand Down Expand Up @@ -214,7 +214,7 @@ void eActionMap::keyPressed(int device, int key, int flags)
} else if (i->m_widget)
{
if (!res)
res = i->m_widget->event(eWidget::evtAction, 0, (void*)i->m_widget_arg);
res = i->m_widget->event(eWidget::evtAction, (void*)i->m_widget_arg, (void*)i->m_widget_arg2 );
}
}
}
Expand Down
20 changes: 9 additions & 11 deletions lib/driver/rcconsole.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,32 +41,30 @@ void eRCConsoleDriver::keyPressed(int)
char data[16];
char *d = data;
int num = read(handle, data, 16);
int code;
int code=-1;

int km = input->getKeyboardMode();

while (num--)
{
// eDebug("console code %02x\n", *d++);
if (km == eRCInput::kmAll)
code = *d++;
else
{
if (*d == 27) // escape code
{
/* skip all this stuff */
return;

/* while (num)
while (num)
{
num--;
if (*++d != '[')
break;
}
code = -1; */
code = -1;
} else
code = *d;
++d;

if (code < 32) /* control characters */
code = -1;
if (code == 0x7F) /* delete */
Expand All @@ -76,15 +74,15 @@ void eRCConsoleDriver::keyPressed(int)
if (code != -1)
for (std::list<eRCDevice*>::iterator i(listeners.begin()); i!=listeners.end(); ++i)
{
eDebug("ascii %08x", code);
(*i)->handleCode(code | 0x8000);
// eDebug("ascii %08x", code);
(*i)->handleCode(/*0x8000|*/code);
}
}
}

void eRCConsole::handleCode(int code)
{
input->keyPressed(eRCKey(this, code, 0));
input->keyPressed(eRCKey(this, code, eRCKey::flagAscii));
}

eRCConsole::eRCConsole(eRCDriver *driver)
Expand Down Expand Up @@ -112,7 +110,7 @@ class eRCConsoleInit
eRCConsoleDriver driver;
eRCConsole device;
public:
eRCConsoleInit(): driver("/dev/stdin"), device(&driver)
eRCConsoleInit(): driver("/dev/vc/0"), device(&driver)
{
}
};
Expand Down
51 changes: 50 additions & 1 deletion lib/driver/rcinput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,43 @@ void eRCDeviceInputDev::handleCode(int rccode)
struct input_event *ev = (struct input_event *)rccode;
if (ev->type!=EV_KEY)
return;

// eDebug("%x %x %x", ev->value, ev->code, ev->type);

if (ev->type!=EV_KEY)
return;

int km = iskeyboard ? input->getKeyboardMode() : eRCInput::kmNone;

// eDebug("keyboard mode %d", km);

if (km == eRCInput::kmAll)
return;

if (km == eRCInput::kmAscii)
{
// eDebug("filtering.. %d", ev->code);
bool filtered = ( ev->code > 0 && ev->code < 61 );
switch (ev->code)
{
case KEY_RESERVED:
case KEY_ESC:
case KEY_TAB:
case KEY_BACKSPACE:
case KEY_ENTER:
case KEY_LEFTCTRL:
case KEY_RIGHTSHIFT:
case KEY_LEFTALT:
case KEY_CAPSLOCK:
filtered=false;
default:
break;
}
if (filtered)
return;
// eDebug("passed!");
}

switch (ev->value)
{
case 0:
Expand All @@ -31,8 +67,21 @@ void eRCDeviceInputDev::handleCode(int rccode)
}
}

eRCDeviceInputDev::eRCDeviceInputDev(eRCInputEventDriver *driver): eRCDevice(driver->getDeviceName(), driver)
eRCDeviceInputDev::eRCDeviceInputDev(eRCInputEventDriver *driver)
:eRCDevice(driver->getDeviceName(), driver), iskeyboard(false)
{
int len=id.length();
int idx=0;
while(idx < len)
{
if (!strncasecmp(&id[idx++], "KEYBOARD", 8))
{
iskeyboard=true;
break;
}
}
eDebug("Input device \"%s\" is %sa keyboard.", id.c_str(), iskeyboard ? "" : "not ");

}

const char *eRCDeviceInputDev::getDescription() const
Expand Down
1 change: 1 addition & 0 deletions lib/driver/rcinput.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

class eRCDeviceInputDev: public eRCDevice
{
int iskeyboard;
public:
void handleCode(int code);
eRCDeviceInputDev(eRCInputEventDriver *driver);
Expand Down
81 changes: 50 additions & 31 deletions lib/gui/einput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,34 +94,54 @@ int eInput::event(int event, void *data, void *data2)
case evtAction:
if (isVisible())
{
switch((int)data2)
if ((int)data == ASCII_ACTIONS)
{
case moveLeft:
m_content->moveCursor(eInputContent::dirLeft);
break;
case moveRight:
m_content->moveCursor(eInputContent::dirRight);
break;
case moveHome:
m_content->moveCursor(eInputContent::dirHome);
break;
case moveEnd:
m_content->moveCursor(eInputContent::dirEnd);
break;
case deleteForward:
m_content->deleteChar(eInputContent::deleteForward);
break;
case deleteBackward:
m_content->deleteChar(eInputContent::deleteBackward);
break;
case toggleOverwrite:
setOverwriteMode(!m_mode);
break;
case accept:
changed();
mayKillFocus();
if ((int)data2 == gotAsciiCode)
{
if (m_content)
{
extern int getPrevAsciiCode(); // defined in enigma.cpp
return m_content->haveKey(getPrevAsciiCode(), m_mode);
}
}
}
else if ((int)data == INPUT_ACTIONS)
{
switch((int)data2)
{
case moveLeft:
if (m_content)
m_content->moveCursor(eInputContent::dirLeft);
break;
case moveRight:
if (m_content)
m_content->moveCursor(eInputContent::dirRight);
break;
case moveHome:
if (m_content)
m_content->moveCursor(eInputContent::dirHome);
break;
case moveEnd:
if (m_content)
m_content->moveCursor(eInputContent::dirEnd);
break;
case deleteForward:
if (m_content)
m_content->deleteChar(eInputContent::deleteForward);
break;
case deleteBackward:
if (m_content)
m_content->deleteChar(eInputContent::deleteBackward);
break;
case toggleOverwrite:
setOverwriteMode(!m_mode);
break;
case accept:
changed();
mayKillFocus();
}
return 1;
}
return 1;
}
return 0;
case evtKey:
Expand All @@ -137,9 +157,8 @@ int eInput::event(int event, void *data, void *data2)
eDebug("focus got in %p", this);
ePtr<eActionMap> ptr;
eActionMap::getInstance(ptr);
ptr->bindAction("InputActions", 0, 0, this);
// bind all keys
ptr->bindAction("", 0, 1, this);
ptr->bindAction("InputActions", 0, INPUT_ACTIONS, this);
ptr->bindAction("AsciiActions", 0, ASCII_ACTIONS, this);
m_have_focus = 1;
eRCInput::getInstance()->setKeyboardMode(eRCInput::kmAscii);
// fixme. we should use a style for this.
Expand All @@ -152,8 +171,8 @@ int eInput::event(int event, void *data, void *data2)
eDebug("focus lostin %p", this);
ePtr<eActionMap> ptr;
eActionMap::getInstance(ptr);
ptr->unbindAction(this, 0);
ptr->unbindAction(this, 1);
ptr->unbindAction(this, INPUT_ACTIONS);
ptr->unbindAction(this, ASCII_ACTIONS);
m_have_focus = 0;
if (m_content)
m_content->validate();
Expand Down
13 changes: 11 additions & 2 deletions lib/gui/einput.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ class eInput: public eWidget
PSignal0<void> changed;

int m_cursor;


enum {
INPUT_ACTIONS,
ASCII_ACTIONS
};

enum InputActions {
moveLeft,
moveRight,
Expand All @@ -25,7 +30,11 @@ class eInput: public eWidget
toggleOverwrite,
accept
};


enum AsciiActions {
gotAsciiCode
};

void setContent(eInputContent *cnt);

void setOverwriteMode(int o);
Expand Down
13 changes: 10 additions & 3 deletions lib/python/Components/Input.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ def right(self):
self.update()

def left(self):
self.currPos -= 1
self.update()
if self.currPos > 0:
self.currPos -= 1
self.update()

def up(self):
if self.text[self.currPos] == "9" or self.text[self.currPos] == " ":
Expand All @@ -73,7 +74,13 @@ def down(self):
def delete(self):
self.text = self.text[:self.currPos] + self.text[self.currPos + 1:]
self.update()


def handleAscii(self, code):
newChar = chr(code)
self.text = self.text[0:self.currPos] + newChar + self.text[self.currPos + 1:]
self.right()
self.update()

def number(self, number):
if self.type == self.TEXT:
newChar = self.numericalTextInput.getKey(number)
Expand Down
16 changes: 13 additions & 3 deletions lib/python/Screens/InputBox.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ def __init__(self, session, title = "", **kwargs):
self["text"] = Label(title)
self["input"] = Input(**kwargs)

self["actions"] = NumberActionMap(["WizardActions", "InputBoxActions"],
self["actions"] = NumberActionMap(["WizardActions", "InputBoxActions", "AsciiActions"],
{
"gotAsciiCode": self.gotAsciiCode,
"ok": self.go,
"back": self.cancel,
"left": self.keyLeft,
Expand All @@ -33,7 +34,12 @@ def __init__(self, session, title = "", **kwargs):
"9": self.keyNumberGlobal,
"0": self.keyNumberGlobal
}, -1)

rcinput = eRCInput.getInstance()
rcinput.setKeyboardMode(rcinput.kmAscii)

def gotAsciiCode(self):
self["input"].handleAscii(getPrevAsciiCode())

def keyLeft(self):
self["input"].left()

Expand All @@ -47,7 +53,11 @@ def keyDelete(self):
self["input"].delete()

def go(self):
rcinput = eRCInput.getInstance()
rcinput.setKeyboardMode(rcinput.kmNone)
self.close(self["input"].getText())

def cancel(self):
self.close(None)
rcinput = eRCInput.getInstance()
rcinput.setKeyboardMode(rcinput.kmNone)
self.close(None)
Loading

0 comments on commit fce04eb

Please sign in to comment.