Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport integration tests: transport suite #2295

Closed
wants to merge 2 commits into from

Conversation

MarcoPolo
Copy link
Collaborator

Related to #2194

This runs the p2p/transport/testsuite on all transports. There is one change made to avoid starting a new listener for every connection, which would fail for QUIC listeners since multiple calls to listen on port 0 will use the same port and fail.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intention behind this PR? The existing transport suite has caused us nothing but pain.

@MarcoPolo
Copy link
Collaborator Author

I wanted to make use of the existing tests and code we had. I didn't know this caused us pain. If the feeling is that this is more effort than it's worth, I can close.

@MarcoPolo
Copy link
Collaborator Author

Closing for lack of interest.

@MarcoPolo MarcoPolo closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants