autonatv2: recover from panics #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
autonatv2-panic
branch
from
460f205
to
96d1106
Compare
MarcoPolo
reviewed
Oct 2, 2024
| @@ -248,6 +250,12 @@ func newDialRequest(reqs []Request, nonce uint64) pb.Message { | |||
|
|
|||
| // handleDialBack receives the nonce on the dial-back stream | |||
| func (ac *client) handleDialBack(s network.Stream) { | |||
| defer func() { | |||
There was a problem hiding this comment.
Do we need to ensure that the stream has been closed?
There was a problem hiding this comment.
Yes. We should reset the stream on panic. aa2caf0
sukunrt
force-pushed
the
autonatv2-panic
branch
from
5bec581
to
aa2caf0
Compare
MarcoPolo
approved these changes
Oct 4, 2024
MarcoPolo
pushed a commit
that referenced
this pull request
Oct 4, 2024
* autonatv2: catch panics * reset streams on panic
sukunrt
added a commit
that referenced
this pull request
Oct 4, 2024
* autonatv2: catch panics * reset streams on panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.