chore: pr comments

libp2p · Oct 25, 2024 · 084e83e · 084e83e
1 parent 71aa34d
commit 084e83e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 20 deletions.
diff --git a/packages/kad-dht/test/rpc/handlers/get-value.spec.ts b/packages/kad-dht/test/rpc/handlers/get-value.spec.ts
@@ -52,7 +52,7 @@ describe('rpc - handlers - GetValue', () => {
 
     handler = new GetValueHandler(components, {
       peerRouting,
-      logPrefix: ''
+      logPrefix: 'dht'
     })
   })
 
@@ -79,7 +79,7 @@ describe('rpc - handlers - GetValue', () => {
     const value = uint8ArrayFromString('world')
     const record = new Libp2pRecord(key, value, new Date())
 
-    await datastore.put(utils.bufferToRecordKey('//record', key), record.serialize().subarray())
+    await datastore.put(utils.bufferToRecordKey('/dht/record', key), record.serialize().subarray())
 
     const msg: Message = {
       type: T,

diff --git a/packages/kad-dht/test/rpc/handlers/put-value.spec.ts b/packages/kad-dht/test/rpc/handlers/put-value.spec.ts
@@ -35,7 +35,7 @@ describe('rpc - handlers - PutValue', () => {
 
     handler = new PutValueHandler(components, {
       validators,
-      logPrefix: ''
+      logPrefix: 'dht'
     })
   })
 
@@ -75,7 +75,7 @@ describe('rpc - handlers - PutValue', () => {
     const response = await handler.handle(sourcePeer, msg)
     expect(response).to.deep.equal(msg)
 
-    const key = utils.bufferToRecordKey('//record', uint8ArrayFromString('hello'))
+    const key = utils.bufferToRecordKey('/dht/record', uint8ArrayFromString('hello'))
     const res = await datastore.get(key)
 
     const rec = Libp2pRecord.deserialize(res)

diff --git a/packages/kad-dht/test/utils/create-peer-id.ts b/packages/kad-dht/test/utils/create-peer-id.ts
@@ -7,20 +7,16 @@ import type { PeerId, PrivateKey } from '@libp2p/interface'
  */
 export async function createPeerIds (length: number): Promise<PeerId[]> {
   return Promise.all(
-    new Array(length).fill(0).map(async () => {
-      const privateKey = await generateKeyPair('Ed25519')
-      return peerIdFromPrivateKey(privateKey)
-    })
+    new Array(length).fill(0).map(async () => createPeerId())
   )
 }
 
 /**
  * Creates a PeerId
  */
 export async function createPeerId (): Promise<PeerId> {
-  const ids = await createPeerIds(1)
-
-  return ids[0]
+  const privateKey = await generateKeyPair('Ed25519')
+  return peerIdFromPrivateKey(privateKey)
 }
 
 export type PeerIdWithPrivateKey = PeerId & {
@@ -32,21 +28,17 @@ export type PeerIdWithPrivateKey = PeerId & {
  */
 export async function createPeerIdsWithPrivateKey (length: number): Promise<PeerIdWithPrivateKey[]> {
   return Promise.all(
-    new Array(length).fill(0).map(async () => {
-      const privateKey = await generateKeyPair('Ed25519')
-      const peerId = peerIdFromPrivateKey(privateKey) as unknown as PeerIdWithPrivateKey
-      peerId.privateKey = privateKey
-
-      return peerId
-    })
+    new Array(length).fill(0).map(async () => createPeerIdWithPrivateKey())
   )
 }
 
 /**
  * Creates a PeerId with a private key
  */
 export async function createPeerIdWithPrivateKey (): Promise<PeerIdWithPrivateKey> {
-  const ids = await createPeerIdsWithPrivateKey(1)
+  const privateKey = await generateKeyPair('Ed25519')
+  const peerId = peerIdFromPrivateKey(privateKey) as unknown as PeerIdWithPrivateKey
+  peerId.privateKey = privateKey
 
-  return ids[0]
+  return peerId
 }