Rust server #3
Merged
Rust server #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mxinden
reviewed
Mar 21, 2023
rust-server/src/main.rs
Outdated
| // Set a custom gossipsub configuration | ||
| let gossipsub_config = gossipsub::ConfigBuilder::default() | ||
| .heartbeat_interval(Duration::from_secs(10)) // This is set to aid debugging by not cluttering the log space | ||
| .validation_mode(gossipsub::ValidationMode::Strict) // This sets the kind of message validation. The default is Strict (enforce message signing) |
There was a problem hiding this comment.
Consider not being strict. Just in case the JS implementation does not sign messages by default. If I am not mistaken, we are in a trusted setup here, right?
There was a problem hiding this comment.
Good point, changed to permissive
Co-authored-by: Max Inden <[email protected]>
|
Seeing the following logs when connecting from the browser with the following multiaddr: |
Co-authored-by: Max Inden <[email protected]>
|
Here are the logs when trying to connect the UI to the daemon: |
|
The Rust server tries to send a ping to the remote: But the remote seems to never reply: Over time, What does the remote peer log? Does it actively ignore the incoming ping streams? For testing purposes you can set |
|
@mxinden I see the ping running ok |
|
The real issue is this. When I enable the following topic subscription I get the following and a closed connection. It looks like the mesh is low, and needs at least 5. I'll try to update the setting |
…ges from rust-server
|
I found the issue for the missing subscribe from the rust-libp2p server to the js-libp2p (or any other) client. Sparsely documented in libp2p/rust-libp2p#3690 for now. Will follow up with more details and push a patch here. Great job everyone surfacing this issue! |
Depend on latest commits on libp2p/rust-libp2p#3625 more specifically libp2p/rust-libp2p@b572895 resolving the missing SUBSCRIBE message previously not send by a rust-libp2p server. Additional refactorings: - Use clap to parse command line arguments. Among other things gives us nice help text and better error messages. - Depend on `libp2p-webrtc` directly as we will remove the re-export from `libp2p`. - Use `futures-timer` to send `Hello World` on a 2 second interval instead of on each `SwarmEvent`. - Redo logging on various levels (warn, info, debug).
4 tasks
|
Fix for the missing SUBSCRIBE will be added with #6. |
Fix missing SUBSCRIBE and refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rust server that does the following:
universal-connectivitytopicTODO