Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: multi-arch-build: use a different output path #1100

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

a-gave
Copy link
Contributor

@a-gave a-gave commented Mar 25, 2024

I apologize for bothering again on this topic, but compiling via imagebuilder once again turns out to be broken.

I did not calculate that a subsequent compilation from the build.yml workflow would delete the subdirectory previously created by the multi-arch-build.yml workflow (e.g. now missing https://github.com/libremesh/lime-feed/tree/gh-pages/master/packages).

This fixes it, telling the multi-arch-build.yml workflow to use a different path for output packages to avoid overwriting.
This updates also packages/lime-system/files/etc/uci-defaults/92_add-lime-repos and README.md accordingly.

This also removes the feeds added by default by buildroot for each feed declared in feeds.conf and resulting in a known opkg error such as the one below:

root@ninux-598775:~# opkg update
[...]
Collected errors:
 * opkg_download: Failed to download http://downloads.openwrt.org/releases/19.07.10/packages/mips_24kc/libremesh/Packages.gz, wget returned 8.
 * opkg_download: Failed to download http://downloads.openwrt.org/releases/19.07.10/packages/mips_24kc/profiles/Packages.gz, wget returned 8.

@ilario
Copy link
Member

ilario commented Mar 25, 2024 via email

@a-gave
Copy link
Contributor Author

a-gave commented Mar 26, 2024

Thanks! It looks great :) And it also allows us to remove one step from the compilation instructions, right? I refer to this one: "Deselect erroneous feeds locations: Image configuration → Separate feed repositories → Enable feed libremesh Image configuration → Separate feed repositories → Enable feed profiles" from this page: https://libremesh.org/development.html#compiling_libremesh_from_source_code Thanks!

On second thought, it seems more correct to me that it is deselected at build time.

update packages/lime-system/files/etc/uci-defaults/92_add-lime-repos
and README.md accordingly
@ilario
Copy link
Member

ilario commented Mar 28, 2024

Ok! Both options (to instruct the user to deselect that or to do it automatically) seem good to me.

@ilario ilario merged commit f7ff091 into libremesh:master Mar 28, 2024
1 check passed
@a-gave
Copy link
Contributor Author

a-gave commented Mar 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants