Enable HDR support in iOS. #15871
Merged
Enable HDR support in iOS. #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoa, that's a big increase in the moltenvk filesize for tvOS. Up 30 MB vs iOS' 200 KB increase. Is that normal / in-line with expectations? |
|
Thanks, didn't even notice that. It should not be as it should basically just be a recompile. Let me look into that. |
warmenhoven
force-pushed
the
warmenhoven/pr/ios-hdr
branch
from
3364cd9 to
89002ce
Compare
|
The "external dependencies" components of moltenvk had somehow been set to create debug builds. Recompiling them as release builds fixed the size issue. Good spot, thanks! |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
* Enable HDR support in iOS. * Enable HDR support in tvOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a small tweak to MoltenVK; it was incorrectly not reporting that iOS/tvOS support the pixel format that RetroArch tries to use for HDR.