Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PipeWire) Fix speedup in the video threaded mode #17406

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 35 additions & 15 deletions audio/drivers/pipewire.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* RetroArch - A frontend for libretro.
* Copyright (C) 2024 - Viachaslau Khalikin
* Copyright (C) 2024-2025 - Viachaslau Khalikin
*
* RetroArch is free software: you can redistribute it and/or modify it under the terms
* of the GNU General Public License as published by the Free Software Found-
Expand Down Expand Up @@ -82,7 +82,7 @@ static void playback_process_cb(void *data)
buf = b->buffer;
p = buf->datas[0].data;
if (p == NULL)
return;
goto done;

/* calculate the total no of bytes to read data from buffer */
req = b->requested * audio->frame_size;
Expand Down Expand Up @@ -115,8 +115,10 @@ static void playback_process_cb(void *data)
buf->datas[0].chunk->stride = audio->frame_size;
buf->datas[0].chunk->size = n_bytes;

done:
/* queue the buffer for playback */
pw_stream_queue_buffer(audio->stream, b);
pw_thread_loop_signal(audio->pw->thread_loop, false);
}

static void pipewire_free(void *data);
Expand Down Expand Up @@ -317,8 +319,7 @@ static void *pipewire_init(const char *device, unsigned rate,

static ssize_t pipewire_write(void *data, const void *buf_, size_t size)
{
int32_t writable;
int32_t avail;
int32_t filled, avail;
uint32_t index;
pipewire_audio_t *audio = (pipewire_audio_t*)data;
const char *error = NULL;
Expand All @@ -327,25 +328,44 @@ static ssize_t pipewire_write(void *data, const void *buf_, size_t size)
return 0; /* wait for stream to become ready */

pw_thread_loop_lock(audio->pw->thread_loop);
writable = spa_ringbuffer_get_write_index(&audio->ring, &index);
avail = audio->highwater_mark - writable;

while (size)
{
filled = spa_ringbuffer_get_write_index(&audio->ring, &index);
avail = audio->highwater_mark - filled;

#if 0 /* Useful for tracing */
RARCH_DBG("[PipeWire]: Playback progress: written %d, avail %d, index %d, size %d\n",
writable, avail, index, size);
RARCH_DBG("[PipeWire]: Ringbuffer utilization: filled %d, avail %d, index %d, size %d\n",
filled, avail, index, size);
#endif

if (size > (size_t)avail)
size = avail;
/* in non-blocking mode we play as much as we can
* in blocking mode we expect a freed buffer of at least the given size
*/
if (size > (size_t)avail)
{
if (audio->pw->nonblock)
{
size = avail;
break;
}
else
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'else' can be omitted

{
pw_thread_loop_wait(audio->pw->thread_loop);
}
}
else
break;
}

if (writable < 0)
RARCH_ERR("%p: underrun write:%u filled:%d\n", audio, index, writable);
if (filled < 0)
RARCH_ERR("[Pipewire]: %p: underrun write:%u filled:%d\n", audio, index, filled);
else
{
if ((uint32_t) writable + size > RINGBUFFER_SIZE)
if ((uint32_t) filled + size > RINGBUFFER_SIZE)
{
RARCH_ERR("%p: overrun write:%u filled:%d + size:%zu > max:%u\n",
audio, index, writable, size, RINGBUFFER_SIZE);
RARCH_ERR("[PipeWire]: %p: overrun write:%u filled:%d + size:%zu > max:%u\n",
audio, index, filled, size, RINGBUFFER_SIZE);
}
}

Expand Down
6 changes: 3 additions & 3 deletions audio/drivers_microphone/pipewire.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,8 @@ static void capture_process_cb(void *data)
}

buf = b->buffer;
p = buf->datas[0].data;
if (p == NULL)
return;
if ((p = buf->datas[0].data) == NULL)
goto done;

offs = SPA_MIN(buf->datas[0].chunk->offset, buf->datas[0].maxsize);
n_bytes = SPA_MIN(buf->datas[0].chunk->size, buf->datas[0].maxsize - offs);
Expand All @@ -125,6 +124,7 @@ static void capture_process_cb(void *data)
index += n_bytes;
spa_ringbuffer_write_update(&microphone->ring, index);

done:
pw_stream_queue_buffer(microphone->stream, b);
}

Expand Down
Loading