-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten improvements #17422
base: master
Are you sure you want to change the base?
Emscripten improvements #17422
Conversation
Please note that the .bc -> .a change is a change that occured in recent toolchain versions and we would need to change all core makefiles on libretro side |
Failing checks are unrelated to this PR. This will likely resolve itself as you push a new commit to this PR. |
@BinBashBanana Why was this closed? |
Rebasing again, I didn't realize it would auto-close |
Android build failure seems unrelated? |
Just a moment, I need to go get lunch :D |
Seems like the only build error now is Emscripten |
Ready and tested with dummy, nestopia, snes9x, and mupen64plus_next (patched). |
If possible, emscripten on the buildbot should be updated (I'm using 3.1.74) - this enables the INITIAL_HEAP setting which gives better control over memory. |
Anything else that needs to be changed before this is merged? |
Overall seems like good changes. Thanks for keeping emscripten build going. |
Description
Reviewers
@LibretroAdmin @m4xw @hunterk