Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten improvements #17422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BinBashBanana
Copy link

Description

  • Canvas is now resized to the correct size, image should no longer be blurry (this may not work in safari)
  • More exported functions added, fixed a bug in cheat manager
    • Added RELOAD_CONFIG command event
  • Added library_platform_emscripten.js to manage more platform functions without using EM_ASM/EM_JS
  • Added a config option to ignore missing assets (currently ozone only) - this enables drawing the fancy cursor
  • Added touch input support (up to 32 touches?)
  • Fixed FP/sRGB FBO detection/support which caused some shader pipelines to break in GLES3, and enables more in GLES2
  • Fixed up emscripten makefile, build script, and web player

Reviewers

@LibretroAdmin @m4xw @hunterk

@m4xw
Copy link
Contributor

m4xw commented Jan 17, 2025

Please note that the .bc -> .a change is a change that occured in recent toolchain versions and we would need to change all core makefiles on libretro side

@LibretroAdmin
Copy link
Contributor

LibretroAdmin commented Jan 17, 2025

Failing checks are unrelated to this PR. This will likely resolve itself as you push a new commit to this PR.

Makefile.emscripten Outdated Show resolved Hide resolved
@LibretroAdmin
Copy link
Contributor

@BinBashBanana Why was this closed?

@BinBashBanana
Copy link
Author

Rebasing again, I didn't realize it would auto-close

@BinBashBanana BinBashBanana reopened this Jan 17, 2025
@BinBashBanana
Copy link
Author

Android build failure seems unrelated?

@BinBashBanana
Copy link
Author

Just a moment, I need to go get lunch :D

@LibretroAdmin
Copy link
Contributor

Seems like the only build error now is Emscripten

@BinBashBanana
Copy link
Author

Ready and tested with dummy, nestopia, snes9x, and mupen64plus_next (patched).

@BinBashBanana
Copy link
Author

If possible, emscripten on the buildbot should be updated (I'm using 3.1.74) - this enables the INITIAL_HEAP setting which gives better control over memory.

@BinBashBanana
Copy link
Author

Anything else that needs to be changed before this is merged?

@RobLoach
Copy link
Member

Overall seems like good changes. Thanks for keeping emscripten build going.

cheat_manager.c Outdated Show resolved Hide resolved
@BinBashBanana
Copy link
Author

One more rebase. Just fixed 3c3611a as well (#15559 needed "override")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants