Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use emar instead of em++/emcc for archiving #33

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

JoeOsborn
Copy link

@JoeOsborn JoeOsborn commented Oct 10, 2023

@LibretroAdmin
Copy link

Will this cause issues on our buildbot?

@JoeOsborn
Copy link
Author

JoeOsborn commented Oct 27, 2023

I don’t think so. This is to fix the builds under modern emsdk versions, but older emsdk versions also provide emar as far as I understand (most cores used it already under emsdk 1.whatever, my similar patch to mrboom was fine, etc).

This allows for this change to go through without breaking bsnes and a handful of other cores with faulty makefiles (for which I have other PRs open): https://git.libretro.com/libretro-infrastructure/libretro-build-emscripten/-/commit/4cb8d69f1bfa04185237960b284c98c25e807ded

@LibretroAdmin LibretroAdmin merged commit b8fbf6c into libretro:master Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants