Add isIssueOf to instance cards #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we can merge this as is (it's technically as simple as it gets). But there is a caveat: we might still want to revise this property (as in even replacing it with a more general one) if we want close alignment to BF (pending a resolution to lcnetdev/bibframe-ontology#88). But only unless use of
kbv:isIssueOfin the newspaper applications isn't feature frozen. If so we have to maintain it (including, in theory, infer if from more general ones if we'd ever want that application to be able to utilize descriptions from other, less specific sources than those we currently remap to use this specific property).