More efficient move calculation for Gaviota and Syzygy #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, can you update the branch to include the commits that are now in main, so that the tests won't fail? |
|
@AttackingOrDefending I just removed the lines you mentioned and integrated the changes from the master branch. The speedup with pushing and popping is nice to hear! |
adbar
force-pushed
the
more_efficient_probing
branch
from
37eeafa to
89f030c
Compare
|
I rebased the branch and the tests now pass on my computer. |
AttackingOrDefending
approved these changes
Jan 8, 2025
MarkZH
approved these changes
Jan 9, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
This PR simplifies the calculation of moves using Gaviota and Syzygy databases, I noticed inefficient lines like values computed twice. The external tests currently don't pass due to a network issue but the rest is fine. This code should run more efficiently and be easier to maintain.
Checklist: