Matchmaking pull back #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already done in Matchmaker.accepted_challenge()
A bot does not need to respond to challenges from itself. Instead of checking Matchmaker.challenge_id, use Challenge.from_self. Plus, this change handles the case where if the bot's user manually creates a challenge for the bot on the lichess website.
This method names the purpose of setting challenge_id to the empty string.
AttackingOrDefending
approved these changes
Feb 3, 2024
AttackingOrDefending
merged commit 180edae
into
lichess-bot-devs:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Simplify how the
Matchmakingclass handles thechallenge_idstring and remove the need to pass instances outside oflichess_bot_main().handle_challenge(), useChallenge.from_selfinstead ofchlng.id != matchmaker.challenge_idto prevent declining challenges originating from the user's bot. TheMatchmakerinstance is no longer needed as an argument.play_game(),matchmaker.challegne_idis already cleared inmatchmaker.accepted_challenge(). There's no need to do so inplay_game(), so there's no need formatchmakerto be a parameter.Matchmaker.challenge_idin order to consolidate repeated code. Should we ever want to allow for multiple matchmaking challenges at once, this should make that simpler to implement.Related Issues:
Inspired by discussion #883
Checklist:
Screenshots/logs (if applicable):
N/A