Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize line endings #915

Merged

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Feb 17, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Make sure changes to line endings don't render diffs useless.

Related Issues:

N/A

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

Make sure changes to line endings don't render diffs useless.
@MarkZH
Copy link
Collaborator Author

MarkZH commented Feb 17, 2024

I just noticed that git blame for test_bot\test_bot.py shows every line was changed by #912, which is annoying when looking at the history of the file. My editor (VS Code) apparently changed the newline character for every line in on of the commits. This should prevent similar problems in the future.

@AttackingOrDefending AttackingOrDefending merged commit 945c139 into lichess-bot-devs:master Feb 18, 2024
15 checks passed
@MarkZH MarkZH deleted the normalize-line-endings branch February 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants