Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_opening_explorer_move when having the black pieces #955

Merged
merged 1 commit into from
May 9, 2024

Conversation

AttackingOrDefending
Copy link
Member

@AttackingOrDefending AttackingOrDefending commented May 8, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

The winrate calculation in get_opening_explorer_move was always from whites perspective, so when playing black, it would choose the worst move available.

Related Issues:

fixes #954

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

@AttackingOrDefending AttackingOrDefending changed the title Update engine_wrapper.py Fix get_opening_explorer_move when having the black pieces May 8, 2024
@MarkZH MarkZH merged commit 7644703 into lichess-bot-devs:master May 9, 2024
15 checks passed
@AttackingOrDefending AttackingOrDefending deleted the opening branch May 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lichess_opening_explorer with move_quality: "good" picks up losing opening lines
2 participants