Allow all commands that start with !eval
to overcome spam rules
#967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Context
When watching bot games, chat spam become very strict when trying to send the same command multiple times, which usually happens for
!eval
command.This seems to be the piece of code responsible of detecting a message as spam. It basically detects duplicated messages (thanks @tsoj!)
There was an attempt to improve this on lichess side Relaxing spam rules for when being a normal user alone with just BOT accounts in chat, but it didn't make it.
Proposal
We can improve spectator experience on our side by allowing multiple commands to return our bot's eval.
The easiest way I could think of is doing so for every command that starts with (
!eval
), i.e.!eval1234
,!evalplease
,!eval with spaces
.This change has been applied to my bot and can be verified right now by watching any of his games and entering those commands one after each other.
Related Issues:
Checklist:
Screenshots/logs (if applicable):