Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append block list from challenge to matchmaking #978

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Jun 18, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Adds an option to the configuration file to add the entries in the challenge: block_list to the matchmaking: block_list. This avoids having to copy one block list into the other.

Related Issues:

Closes #975

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

@AttackingOrDefending
Copy link
Member

Shouldn't we set a default value for include_challenge_block_list in config.py?

@AttackingOrDefending AttackingOrDefending merged commit 562bde1 into lichess-bot-devs:master Jun 19, 2024
15 checks passed
@MarkZH MarkZH deleted the copy-block-list branch June 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid having to duplicate block_list in challenge and matchmaking sections
2 participants