Add more tests #982
Merged
Add more tests #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkZH
reviewed
Jun 20, 2024
Comment on lines
-1071
to
+1079
| best_wdl = name_to_wld[data["moves"][0]["category"]] | ||
| best_wdl = name_to_wld[data["moves"][0]["category"]] * -1 | ||
|
|
||
| def good_enough(possible_move: LichessEGTBMoveType) -> bool: | ||
| return name_to_wld[possible_move["category"]] == best_wdl | ||
| return name_to_wld[possible_move["category"]] * -1 == best_wdl | ||
|
|
||
| possible_moves = list(filter(good_enough, data["moves"])) | ||
| if len(possible_moves) > 1: | ||
| move_list = [move["uci"] for move in possible_moves] | ||
| wdl = best_wdl * -1 | ||
| wdl = best_wdl |
There was a problem hiding this comment.
Am I wrong, or do these code changes result in no change in behavior?
There was a problem hiding this comment.
This doesn't change anything. I just though that the code would be easier to understand because the correct wdl is with the * -1, but we can obviously test with the wrong wdl and correct it at the end as we are currently doing. The bug was in line 1105.
MarkZH
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Add some tests for external moves. A lot more should be added before #920 can be closed.
Also fixes a bug in
engine_wrapperfound while creating these tests.Related Issues:
#920
Checklist:
Screenshots/logs (if applicable):