Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional fields in public user endpoint #333

Closed
wants to merge 7 commits into from
Closed

add optional fields in public user endpoint #333

wants to merge 7 commits into from

Conversation

jalpp
Copy link
Contributor

@jalpp jalpp commented Apr 12, 2024

solves #159 adding optional fields in description and linking required faq/TOS URLs to better understand the API sample

@fitztrev
Copy link
Member

Would it be better to add these to the schemas as property descriptions?

   disabled:
     type: boolean
     example: false
+    description: Only appears if a user's account is closed

image

@jalpp
Copy link
Contributor Author

jalpp commented Apr 12, 2024

Would it be better to add these to the schemas as property descriptions?

   disabled:

     type: boolean

     example: false

+    description: Only appears if a user's account is closed

image

Oh yes! 😅 I'm used to readme format, I will add that and re create the PR! Thanks

@jalpp jalpp closed this Apr 12, 2024
@jalpp jalpp deleted the master branch April 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants