We have two paginators 😱 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
force-pushed
the
remove-one-paginator
branch
from
fc4ca05
to
68b3def
Compare
lenguyenthanh
force-pushed
the
remove-one-paginator
branch
from
68b3def
to
14ae10f
Compare
`playJson` only provides extensions and generic type class transformation. A new file `lila.Json` is created to provide lila's specific instance for play-json type class.
lenguyenthanh
commented
Apr 10, 2024
build.sbt
Outdated
| ) | ||
| ) | ||
| .dependsOn(core, model, playJson) | ||
| .dependsOn(core, lila) |
There was a problem hiding this comment.
play-json now depends on lila because paginator depends on future extensions or is it?
There was a problem hiding this comment.
Reverted this in the other commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And they're a bit different at
mapfutureList, I guess that's why We broken in prod yesterday.And either We remove
model, it has only one file now, or maybe We can add more types into it.