Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/val 1404 eip 7251 head watcher alerts for new el requests #58

Merged
merged 27 commits into from
Feb 4, 2025
Merged

Feature/val 1404 eip 7251 head watcher alerts for new el requests #58

merged 27 commits into from
Feb 4, 2025

Conversation

dputko
Copy link

@dputko dputko commented Dec 19, 2024

No description provided.

AlexanderLukin
AlexanderLukin reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@AlexanderLukin AlexanderLukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the very high-quality PR. Excellent work! I haven't found anything critical. All comments are mostly suggestions/improvements.

tests/eip7251/__init__.py Outdated Show resolved Hide resolved
tests/eip7251/conftest.py Outdated Show resolved Hide resolved
src/handlers/consolidation.py Outdated Show resolved Hide resolved
src/handlers/consolidation.py Outdated Show resolved Hide resolved
src/handlers/consolidation.py Outdated Show resolved Hide resolved
src/handlers/el_triggered_exit.py Outdated Show resolved Hide resolved
src/variables.py Outdated Show resolved Hide resolved
tests/eip7251/conftest.py Outdated Show resolved Hide resolved
tests/eip7251/test_consolidations.py Outdated Show resolved Hide resolved
src/watcher.py Outdated Show resolved Hide resolved
@AlexanderLukin
Copy link
Contributor

Also would be nice if you could check why two CI tasks have not passed.

dputko and others added 16 commits December 23, 2024 11:56
@dputko @AlexanderLukin
more clear alert summary
13deb61 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
more clear alert summary
be7d453 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
more clear alert summary
ba8e56d 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
Update src/handlers/el_triggered_exit.py
3e7617c 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
Update src/handlers/consolidation.py
fb1a38c 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
Update src/handlers/el_triggered_exit.py
824d994 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
Update src/handlers/el_triggered_exit.py
d652744 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko @AlexanderLukin
Update src/handlers/el_triggered_exit.py
f8c7d92 
Co-authored-by: AlexanderLukin <[email protected]>
@dputko
feat(val-1404): naming, docs, etc after review
73e1ac6 
feat(val-1404): naming, docs, etc after review
@dputko
fix: remove unnecessary curl version pinning; correct keyword casing …
33475b5 
…to prevent Docker warnings; fix LegacyKeyValueFormat for ENV
@dputko
fix: correct keyword casing to prevent Docker warnings; fix LegacyKey…
c5d30f7 
…ValueFormat for ENV
@dputko
fix: ok, pin curl version
a17b7d5
@dputko
fix: formatting
0e52491
@dputko
fix: linter
149d827
@dputko
fix: mypy
64ed4c2
@dputko
feat(val-1404): group similar alerts
c25dc57
@dputko dputko requested a review from AlexanderLukin January 15, 2025 19:33
@dputko dputko marked this pull request as ready for review January 30, 2025 06:52
@dputko dputko merged commit 6b973ff into develop Feb 4, 2025
7 checks passed
@dputko dputko deleted the feature/val-1404-eip-7251-head-watcher-alerts-for-new-el-requests branch February 4, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderLukin AlexanderLukin AlexanderLukin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dputko @AlexanderLukin