first try #25

YuvalSal99 · 2023-05-13T11:30:04Z

No description provided.

jit-ci · 2023-05-13T11:30:26Z

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

sonatype-lift · 2023-05-13T11:36:18Z

StateCap.py

@@ -68,51 +68,60 @@
    'Wyoming' : 'Cheyenne',
 }

-
 def capital_of_Idaho():


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-13T11:36:19Z

StateCap.py

    pass

 def all_capitals():
-    # Your code here
+    capitals = list(STATES_CAPITALS.values())
+    print('capitals =' ,capitals)


E203: whitespace before ','

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-13T11:36:21Z

StateCap.py

    pass

 def all_capitals():
-    # Your code here
+    capitals = list(STATES_CAPITALS.values())
+    print('capitals =' ,capitals)


E231: missing whitespace after ','

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-13T16:06:43Z

StateCap.py

-
-def test_capital_to_state_unknown():
-    with pytest.raises(KeyError):
-        get_state('')


 def main():


E303: too many blank lines (4)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:48Z

strings.py

+"""
+
+
+string='monty pythons flying circus'


E225: missing whitespace around operator

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

strings.py 28

strings.py 34

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:50Z

strings.py

    pass


 def reversed_words(a_string):
-    pass
+     spl = a_string.split()


E111: indentation is not a multiple of 4

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

strings.py 41

strings.py 42

strings.py 43

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:52Z

strings.py

    pass


 def reversed_words(a_string):
-    pass
+     spl = a_string.split()


E117: over-indented

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:54Z

strings.py

+    for i in a_string:
+        temp = temp + i
+        if j == 3 :
+                new_string.append(temp)


E117: over-indented

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:55Z

strings.py

+    print('Start:' + a_string)
+    for i in a_string:
+        temp = temp + i
+        if j == 3 :


E203: whitespace before ':'

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:57Z

strings.py


-def test_four_char_strings():
-    s = 'monty pythons flying circus'
-    assert four_char_strings(s) == ['mont', 'y py', 'thon', 's fl', 'ying', ' cir', 'cus']


 def main():


E303: too many blank lines (3)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-19T12:16:59Z

strings.py

-
+    no_duplicates(string)
+    reversed_words(string)
+    four_char_strings(string)

 if __name__ == '__main__':


E305: expected 2 blank lines after class or function definition, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:31:57Z

StateCap.py

+            flag = 1
+    if flag == 0:
+        raise KeyError("value exist")
+    return state_input

 def test_state_to_capital():


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:31:59Z

strings.py


+    pass

 def test_no_duplicates():


E302: expected 2 blank lines, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:32:01Z

StateCap.py


+def main():
+    return pytest.main(["StateCap.py"])

 if __name__ == '__main__':


E305: expected 2 blank lines after class or function definition, found 1

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:32:03Z

strings.py

-    pass
+     spl = a_string.split()
+     reverse = spl[::-1]
+     return reverse


E111: indentation is not a multiple of 4

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:32:05Z

strings.py

-
+
+
+


W391: blank line at end of file

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-05-31T19:32:07Z

strings.py

+                sort = sort + i
+    yep = sorted(sort)
+    string=''.join(yep)
+    return string
    pass


vulture-100: unreachable code after 'return'

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

strings.py 34

strings.py 53

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

first try

666fa02

sonatype-lift bot reviewed May 13, 2023

View reviewed changes

python final

515fc21

sonatype-lift bot reviewed May 13, 2023

View reviewed changes

strings project

7473fb7

sonatype-lift bot reviewed May 19, 2023

View reviewed changes

YuvalSal99 added 2 commits May 31, 2023 19:28

last commit

658b53d

last commit

50725a1

sonatype-lift bot reviewed May 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first try #25

first try #25

YuvalSal99 commented May 13, 2023

jit-ci bot commented May 13, 2023

sonatype-lift bot May 13, 2023

sonatype-lift bot May 13, 2023

sonatype-lift bot May 13, 2023

sonatype-lift bot May 13, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 19, 2023

sonatype-lift bot May 31, 2023

sonatype-lift bot May 31, 2023

sonatype-lift bot May 31, 2023

sonatype-lift bot May 31, 2023

sonatype-lift bot May 31, 2023

sonatype-lift bot May 31, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

first try #25

Are you sure you want to change the base?

first try #25

Conversation

YuvalSal99 commented May 13, 2023

jit-ci bot commented May 13, 2023

sonatype-lift bot May 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 19, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment

sonatype-lift bot May 31, 2023

Choose a reason for hiding this comment