Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force TFP modules to load, fix model init #5

Merged
merged 12 commits into from
Jun 27, 2024

Conversation

hriebl
Copy link
Contributor

@hriebl hriebl commented Jun 26, 2024

Fixes #4. The problem seems to be caused by a recent reticulate update, probably 1.36. Since then, the TFP modules fail to load when they are required, which is fixed by this PR by introducing a dummy access to these modules.

@hriebl hriebl requested a review from jobrachem June 26, 2024 22:44
@hriebl hriebl linked an issue Jun 26, 2024 that may be closed by this pull request
@jobrachem
Copy link
Contributor

Hi @hriebl, good to "see" you here again 😊 There still seems to be a problem with the R CMD check here, from a first quick glance it appears to be related to the pygraphviz installation.

@jobrachem
Copy link
Contributor

Great work, thank you @hriebl !

@jobrachem jobrachem merged commit 53a0271 into main Jun 27, 2024
3 checks passed
@jobrachem jobrachem deleted the 4-liesel-model-definition-fails-since-recently branch June 27, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liesel model definition fails since recently
2 participants