fix: set body to null if given empty buffer #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised for: #127
Here's a PR that verifies the body is null. If the result data is an empty buffer, pass null as body instead.
Ideally I would like to verify the node16-18 behaviour but the tests here hard-code the
fetch
andResponse
implementation to utilisenode-fetch
which behaves differently to node18s nativefetch
that utilisesundici
.