LPD-42578 Add "Clear" Action to Remove Selection

[chestofwonders]

Issue: https://liferay.atlassian.net/browse/LPD-42578

Add "Clear" Action to Remove Selection

⚠️ FF LPD-42570 must be enabled

The goal of this PR is to provide a button to clear all selected items in data sets

Acceptance Criteria

• When some items on any page are selected, it's shown a "Clear" button
• Clicking the "Clear" button deselect all items, including those across other pages
• The button works for all visualization modes

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:sf

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26ff042a7230aca438731909c0ff739a4ecaa938

Sender Branch:

Branch Name: LPD-42578
Branch GIT ID: e1a799101f6affe07f9cfd6b887ebc4a9d15c293

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#7592

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#4763 - 2025-02-26[00:15:55]

Testray Build ID:151145550


Testray Importer:publish-testray-report#27535

[juanjofgliferay]

Just wondering if we can pass a null value or a string (all) to this function so we can set the state as and empty array instead of iterating over all items in the FrontendDataSet#deselectItems?

[chestofwonders]

I'm personally more on the side of keeping the API of the methods simple... how about asking a question at the beginning of the implementation of deselectItems? Asking if selectedItemsValues ​​has the same length as the parameter sent, should work... 😔

[juanjofgliferay]

Agree on having a simple API. What you suggest is fine 👌

[juanjofgliferay]

LGTM. Just a question inline

[markocikos]

@chestofwonders please see comment inline

[markocikos]

While this is technically correct, it's a bad pattern. You never want to push callbacks down to child components. The reason is it violates separation of concerns; with this your child component contains logic that is implemented on the parent level.

Instead, you want to have a generic callback in the child component, that makes sense for that component in isolation. Something like onClear or onClearClick or onClearButtonClick prop in BulkActions, that is propagated through onBulkActionsClear prop in ManagementBar, and ultimately implemented where the state is, in FrontendDataSet.

[chestofwonders]

I've refactored it. Probably there's more stuff around the whole FrontendDataSet structure we want to address... maybe make an more extensive use of the Context, but for now should be enough, I think

[markocikos]

@chestofwonders looks good, just a small nit in comment

[markocikos]

@chestofwonders LGTM! ✨

[chestofwonders]

ci:forward

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

[liferay-continuous-integration]

❌ ci:test:relevant - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58

Upstream Comparison:

Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58
Jenkins Build URL: EE Development Acceptance (master) - 1211 - 2025-03-03[11:50:25]

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

• test-portal-acceptance-pullrequest(master)

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest(master)

   Job Results:

   0 Jobs Passed.
   1 Job Failed.

   A CI failure has occurred. CI Infrastructure has been notified. Please try again later or contact CI Infrastructure for an update.

For upstream results, click here.

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

[liferay-continuous-integration]

❌ ci:test:sf - 0 out of 1 jobs passed in 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58

Sender Branch:

Branch Name: LPD-42578
Branch GIT ID: eda8aedf32aa91bba666af10c5368074b644264f

0 out of 1jobs PASSED

1 Failed Jobs:

• test-portal-source-format

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/apps/frontend-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/management_bar/ManagementBar.js
     [exec]      35:11  error  'deselectItems' is not defined.  no-undef
     [exec]    
     [exec]    ✖ 1 problem (1 error, 0 warnings)
     [exec]    
     [exec]    
     [exec] ❌ CI checks failed.
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] > Get more help at https://help.gradle.org.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#14608

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - chestofwonders > liferay-frontend - PR#4763 - 2025-03-04[08:30:20]

Testray Build ID:156420338


Testray Importer:publish-testray-report#33872

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#4158

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#4763 - 2025-03-04[08:30:22]

Testray Build ID:156420342


Testray Importer:publish-testray-report#16412

[chestofwonders]

ci:test:sf

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58

Sender Branch:

Branch Name: LPD-42578
Branch GIT ID: cc10d62588c40340f6babcbc7a219b572b911bfe

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[chestofwonders]

ci:forward

[liferay-continuous-integration]

CI is automatically triggering the following test suites:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

•     ci:test:relevant
•     ci:test:sf
•     ci:test:stable

[liferay-continuous-integration]

Skipping previously passed test suites:

• ci:test:sf

[liferay-continuous-integration]

❌ ci:test:relevant - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58

Upstream Comparison:

Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58
Jenkins Build URL: EE Development Acceptance (master) - 1211 - 2025-03-03[11:50:25]

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

• test-portal-acceptance-pullrequest(master)

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest(master)

   Job Results:

   0 Jobs Passed.
   1 Job Failed.

   A CI failure has occurred. CI Infrastructure has been notified. Please try again later or contact CI Infrastructure for an update.

For upstream results, click here.

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#12755

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - chestofwonders > liferay-frontend - PR#4763 - 2025-03-04[10:02:02]

Testray Build ID:156460939


Testray Importer:publish-testray-report#27872

[liferay-continuous-integration]

Jenkins Build:test-portal-source-format#7630

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#4763 - 2025-03-04[09:34:42]

Testray Build ID:156511159


Testray Importer:publish-testray-report#28978

[chestofwonders]

ci:test:relevant

[liferay-continuous-integration]

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 26 out of 30 jobs passed in 1 hour 48 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58

Upstream Comparison:

Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58
Jenkins Build URL: EE Development Acceptance (master) - 1211 - 2025-03-03[11:50:25]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

ci:test:relevant - 26 out of 30 jobs PASSED

4 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• central-requirements
  • central-requirements/0/0
• functional-smoke-tomcat90-mysql57_stable
  • functional-smoke-tomcat90-mysql57_stable/0/0
• functional-upgrade-tomcat90-mysql57_stable
  • functional-upgrade-tomcat90-mysql57_stable/0/0
  • functional-upgrade-tomcat90-mysql57_stable/0/1
  • functional-upgrade-tomcat90-mysql57_stable/0/2
• js-unit
  • js-unit/0/0
  • js-unit/1/0
• modules-compile
  • modules-compile/0/0
  • modules-compile/0/1
  • modules-compile/0/2
  • modules-compile/0/3
  • modules-compile/0/4
  • modules-compile/0/5
  • modules-compile/0/6
  • modules-compile/0/7
  • modules-compile/0/8
  • modules-compile/0/9
  • modules-compile/0/10
  • modules-compile/0/11
  • modules-compile/0/12
• modules-integration-mysql57_stable
  • modules-integration-mysql57_stable/0/0
• modules-semantic-versioning
  • modules-semantic-versioning/0/0
• modules-unit_stable
  • modules-unit_stable/0/0
• playwright-js-tomcat90-mysql57
  • playwright-js-tomcat90-mysql57/0/0
  • playwright-js-tomcat90-mysql57/1/0
  • playwright-js-tomcat90-mysql57/2/0
  • playwright-js-tomcat90-mysql57/2/1
• playwright-js-tomcat90-mysql57_stable
  • playwright-js-tomcat90-mysql57_stable/0/0
• unit_stable
  • unit_stable/0/0

26 Successful Jobs:

For more details click here.

---

Failures unique to this pull:

1. playwright-js-tomcat90-mysql57/0/0 - Playwright Report

   1. frontend-data-set-web/styles.spec.ts

      1. Width of columns can be set with CSS
   2. frontend-data-set-web/customized.spec.ts

      1. Check FDS initial state
      2. Check behavior of custom views
      3. Check behavior of item actions
      4. Check selection behavior
      5. Hide column and assert correct visibility of columns
      6. ...
2. playwright-js-tomcat90-mysql57/2/0 - Playwright Report

   1. frontend-data-set-admin-web/tests/data-set-admin/creationActions.spec.ts

      1. Cancel creating a creation action
      2. Check interactive options in creation action form
      3. Create and edit a creation action of type "Link"
      4. Create and edit a creation action of type "Modal"
      5. Create and edit a creation action of type "Side Panel"
      6. ...
   2. frontend-data-set-admin-web/tests/data-set-admin/clientExtensionFilters.spec.ts

      1. Can create a Client Extension Filter in DSM
      2. Can deactivate and activate a Client Extension Filter in DSM
      3. Can not create a Client Extension Filter in DSM
   3. frontend-data-set-admin-web/tests/data-set-admin/dataSetsPermissions.spec.ts

      1. A user with "Add Object Entry" permission
      2. A user with "Delete" permission
      3. A user with "View" and "Permissions" permission
      4. A user with only "View" permission
      5. A user without "Add Object Entry" permission
      6. ...
   4. ...
3. playwright-js-tomcat90-mysql57/2/1 - Playwright Report

   1. frontend-data-set-admin-web/tests/data-set-fragment/itemActions.spec.ts

      1. Empty Item Actions in Data Set fragment › Item Action button does not appear if there is no item action
      2. Item Actions in Data Set fragment › Link Item Action (single action) is shown in the fragment
      3. Item Actions in Data Set fragment › Link, Modal and Side Panel Item Actions (multiple actions) are shown in fragment
   2. frontend-data-set-admin-web/tests/data-set-admin/visualizationModes.spec.ts

      1. Visualization Modes in Data Set Manager › Add a field and assert its added to the last position in the table and assert fields can be reordered using a keyboard
      2. Visualization Modes in Data Set Manager › Assert the CellRenderer is displayed
      3. Visualization Modes in Data Set Manager › Check cancel in table visualization mode
      4. Visualization Modes in Data Set Manager › Check field edition in table visualization mode @LPS-176051, @LPS-178736
      5. Visualization Modes in Data Set Manager › Check modal field selection allows check and uncheck fields @LPS-174141, @LPS-185228, @LPS-179282
      6. ...
   3. frontend-data-set-admin-web/tests/data-set-fragment/dataSets.spec.ts

      1. An unauthorized user accessing a page with a data set fragment
      2. Assign a data set to the "Data Set" fragment, change and delete assignment
      3. Data set selection modal shows a "No results found" message when there are no data sets created
   4. ...

---

Failures in common with acceptance upstream results at 4281f9b:

1. playwright-js-tomcat90-mysql57/2/1 - Playwright Report

   1. frontend-data-set-admin-web/tests/data-set-fragment/dataSets.spec.ts

      1. "Data Set" fragment can display different sources of data: StructuredContentSchema, UserSchema, TaxonomyVocabularySchema
   2. frontend-data-set-admin-web/tests/data-set-fragment/creationActions.spec.ts

      1. Creation Actions in Data Set fragment › Show the Creation Actions menu if more than one Creation Action is defined

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz

[liferay-continuous-integration]

Jenkins Build:test-portal-acceptance-pullrequest(master)#11155

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4763

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - chestofwonders > liferay-frontend - PR#4763 - 2025-03-05[00:06:09]

Testray Build ID:156864848


Testray Importer:publish-testray-report#26282