LPD-49651 Create Playwright test for frontendDataSetQuickActions #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-49651 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6294 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4767 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - fortunatomaldonado > liferay-frontend - PR#4767 - 2025-02-26[12:50:42] Testray Build ID:Testray Importer:publish-testray-report#7070 |
markocikos
reviewed
Mar 3, 2025
There was a problem hiding this comment.
@fortunatomaldonado looks good, just some naming nits inline
Comment on lines
+819
to
+821
| const quickActionPencilIcon = page | ||
| .getByRole('link', {name: 'Sample Edit'}) | ||
| .nth(0); |
There was a problem hiding this comment.
PencilIcon is more of an implementation detail, this is better named something like sampleEditQuickActionLink.
| .getByRole('link', {name: 'Sample Edit'}) | ||
| .nth(0); | ||
|
|
||
| const firstTableHeadCell = page.locator('.cell-select'); |
There was a problem hiding this comment.
As there is no first(), this is either incorrect, or misleadingly named. This should be selectCells, or firstSelectCell if you add in first().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-49571
Created playwright test for quick action buttons.
Please let me know if there are any questions or comments about this.
Thank you!