LPD-49581 Migrate remaining LocalFile.FrontendDataSetFilters to PW #4778

thektan · 2025-03-05T20:10:47Z

Task: https://liferay.atlassian.net/browse/LPD-49570
Subtask: https://liferay.atlassian.net/browse/LPD-49581

Migrates the tests from FrontendDataSetFilters.testcase to Playwright
All of the tests are under a single test block called 'Check behavior of filters'

Tests not migrated:

LPS-150047. Assert management bar will render.
- Not necessary since if the filters are being interacted with, the presence of the management bar is already being checked
LPS-150047. Assert results can be correctly filtered when using the status filter.
- Filter selection is already checked through "selecting a filter"

liferay-continuous-integration · 2025-03-05T20:10:53Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2025-03-05T20:56:59Z

❌ ci:test:sf - 0 out of 1 jobs passed in 13 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Sender Branch:

Branch Name: LPD-49570_LPD-49581_MigrateRemainingLocalFileFrontendDataSetFiltersToPW
Branch GIT ID: 8e51e179ed7f88d2e03f35b0fd759c330b5f0fb0

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec] Done in 23.24s.
     [exec] 
     [exec] > Task :portalYarnCheckFormat
     [exec] Gradle build finished at 2025-03-05 20:54:15.722.
     [exec] 
     [exec] BUILD SUCCESSFUL in 53s
     [exec] 3 actionable tasks: 3 executed
     [exec] 
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-12-53-31.html
     [exec] A fine-grained performance profile is available: use the --scan option.
[beanshell] Executing Gradle task: packageRunCheckFormat
     [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
     [exec] Daemon will be stopped at the end of the build 
     [exec] > Task :downloadNode
     [exec] 
     [exec] > Task :npmInstall
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] added 130 packages, and audited 134 packages in 5s
     [exec] 
     [exec] 23 packages are looking for funding
     [exec]   run `npm fund` for details
     [exec] 
     [exec] found 0 vulnerabilities
     [exec] 
     [exec] > Task :packageRunCheckFormat
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] > @liferay/[email protected] checkFormat
     [exec] > tsc
     [exec] 
     [exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3526,22): error TS2304: Cannot find name 'ObjectField'.

thektan · 2025-03-05T21:00:05Z

ci:test:frontend

liferay-continuous-integration · 2025-03-05T21:05:22Z

Jenkins Build:test-portal-source-format#6779

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4778

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - thektan > liferay-frontend - PR#4778 - 2025-03-05[12:44:21]

Testray Build ID:157280443

Testray Importer:publish-testray-report#26300

liferay-continuous-integration · 2025-03-05T21:17:06Z

❌ ci:test:frontend - 0 out of 1 jobs passed in 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Upstream Comparison:

Branch GIT ID: 4281f9b41f4c84911eaaf42439d4bf4905772f58
Jenkins Build URL: EE Development Acceptance (master) - 1211 - 2025-03-03[11:50:25]

ci:test:frontend - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

0 Jobs Passed.
1 Job Failed.

POSHI Validation Failure

     [exec] 4 errors in POSHI
     [exec] 
     [exec] Unable to find class FrontendDataSetFilters at:
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-product-test/src/testFunctional/tests/CPCommerceProducts.testcase:2028
     [exec]   2021 |                AssertElementPresent(
     [exec]   2022 |                    key_filter = \$\{filterItemName\},
     [exec]   2023 |                    locator1 = "FrontendDataSet#FILTER_OPTION");
     [exec]   2024 |            \}
     [exec]   2025 |        \}
     [exec]   2026 |
     [exec]   2027 |        task ("When the admin searches for specific filters") \{
     [exec] > 2028 |            FrontendDataSetFilters.searchFilter(searchTerm = "Type");
     [exec]   2029 |        \}
     [exec]   2030 |
     [exec]   2031 |        task ("Then only the matching results are shown in the list") \{
     [exec]   2032 |            AssertElementPresent(
     [exec]   2033 |                key_filter = "Product Type",
     [exec]   2034 |                locator1 = "FrontendDataSet#FILTER_OPTION");
     [exec]   2035 |
     [exec] 
     [exec] 
     [exec] Unable to find class FrontendDataSetFilters at:
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-product-test/src/testFunctional/tests/CPCommerceOrders.testcase:1456
     [exec]   1449 |
     [exec]   1450 |            Click(locator1 = "FrontendDataSet#ADD_FILTER_BUTTON");
     [exec]   1451 |
     [exec]   1452 |            AssertElementPresent(
     [exec]   1453 |                key_entryName = \$\{orderId\},
     [exec]   1454 |                locator1 = "CommerceNavigation#ENTRY_NAME");
     [exec]   1455 |
     [exec] > 1456 |            FrontendDataSetFilters.resetFilter();
     [exec]   1457 |
     [exec]   1458 |            FrontendDataSetFilters.openFilters();
     [exec]   1459 |
     [exec]   1460 |            Type.sendKeys(
     [exec]   1461 |                key_dateId = "from-orderDate",
     [exec]   1462 |                locator1 = "FrontendDataSet#FILTER_DATE_RANGE",
     [exec]   1463 |                value1 = "15/10/2023");
     [exec] 
     [exec] 
     [exec] Unable to find class FrontendDataSetFilters at:
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-product-test/src/testFunctional/tests/CPCommerceOrders.testcase:1458
     [exec]   1451 |
     [exec]   1452 |            AssertElementPresent(
     [exec]   1453 |                key_entryName = \$\{orderId\},
     [exec]   1454 |                locator1 = "CommerceNavigation#ENTRY_NAME");
     [exec]   1455 |
     [exec]   1456 |            FrontendDataSetFilters.resetFilter();
     [exec]   1457 |
     [exec] > 1458 |            FrontendDataSetFilters.openFilters();
     [exec]   1459 |
     [exec]   1460 |            Type.sendKeys(
     [exec]   1461 |                key_dateId = "from-orderDate",
     [exec]   1462 |                locator1 = "FrontendDataSet#FILTER_DATE_RANGE",
     [exec]   1463 |                value1 = "15/10/2023");
     [exec]   1464 |
     [exec]   1465 |            Type.sendKeys(
     [exec] 
     [exec] 
     [exec] Unable to find class FrontendDataSetFilters at:
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/commerce/commerce-product-test/src/testFunctional/tests/CPCommerceOrders.testcase:1434
     [exec]   1427 |                category = "Order Management",
     [exec]   1428 |                portlet = "Orders");
     [exec]   1429 |        \}
     [exec]   1430 |
     [exec]   1431 |        task ("Then the admin can filter the order by Date Range") \{
     [exec]   1432 |            var orderId = CommerceJSONOrdersAPI._getCommerceOrder();
     [exec]   1433 |
     [exec] > 1434 |            FrontendDataSetFilters.openFilters();
     [exec]   1435 |
     [exec]   1436 |            Click(
     [exec]   1437 |                key_filter = "Order Date Range",
     [exec]   1438 |                locator1 = "FrontendDataSet#FILTER_OPTION");
     [exec]   1439 |
     [exec]   1440 |            Type.sendKeys(
     [exec]   1441 |                key_dateId = "from-orderDate",
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] > Task :validatePoshi FAILED

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

thektan · 2025-03-05T21:20:43Z

ci:test:frontend

liferay-continuous-integration · 2025-03-05T21:23:18Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6352

Jenkins Report:jenkins-report.html

Jenkins Suite:frontend

Pull Request:liferay-frontend#4778

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:frontend - thektan > liferay-frontend - PR#4778 - 2025-03-05[13:10:20]

Testray Build ID:157311374

Testray Importer:publish-testray-report#36711

liferay-continuous-integration · 2025-03-05T23:21:53Z

❌ ci:test:frontend - 33 out of 51 jobs passed in 2 hours

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_6353

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Upstream Comparison:

Branch GIT ID: d6224e8cb32a191c5c0793f4ae7d1920018e8f6d
Jenkins Build URL: EE Development Acceptance (master) - 1212 - 2025-03-05[08:36:03]

ci:test:frontend - 33 out of 51 jobs PASSED

18 Failed Jobs:

33 Successful Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-03-05T23:27:47Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6353

Jenkins Report:jenkins-report.html

Jenkins Suite:frontend

Pull Request:liferay-frontend#4778

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:frontend - thektan > liferay-frontend - PR#4778 - 2025-03-05[13:20:57]

Testray Build ID:157521943

Testray Importer:publish-testray-report#36713

thektan · 2025-03-06T00:25:27Z

ci:test:sf

liferay-continuous-integration · 2025-03-06T00:30:35Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

Sender Branch:

Branch Name: LPD-49570_LPD-49581_MigrateRemainingLocalFileFrontendDataSetFiltersToPW
Branch GIT ID: 70c6de82fda12780f593dd1a45d255c22af1a4b7

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-03-06T00:32:44Z

Jenkins Build:test-portal-source-format#6781

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4778

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - thektan > liferay-frontend - PR#4778 - 2025-03-05[16:25:38]

Testray Build ID:157635808

Testray Importer:publish-testray-report#26303

thektan · 2025-03-06T00:51:24Z

✅ No related failures from ci:test:frontend

customized.spec.ts tests pass https://testray.liferay.com/#/project/35392/routines/45357/build/157521943?filter=%7B%22testrayCaseName%22%3A%22customized.spec.ts%22%7D&filterSchema=buildResults&page=1
Checked case result history on failing tests and they show tests failing in other PRs as well

LPD-49581 Organize customized PW tests by feature

afb0d1e

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure ci:test:relevant - failure ci:test:stable - failure and removed ci:test:sf - pending labels Mar 5, 2025

liferay-continuous-integration added ci:test:frontend - pending ci:test:frontend - failure and removed ci:test:frontend - pending labels Mar 5, 2025

LPD-49581 Move to Playwright: Check behavior of filters

70c6de8

thektan force-pushed the LPD-49570_LPD-49581_MigrateRemainingLocalFileFrontendDataSetFiltersToPW branch from 8e51e17 to 70c6de8 Compare March 5, 2025 21:20

liferay-continuous-integration added ci:test:frontend - pending and removed ci:test:frontend - failure labels Mar 5, 2025

liferay-continuous-integration added ci:test:frontend - failure and removed ci:test:frontend - pending labels Mar 5, 2025

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending ci:test:relevant - failure labels Mar 6, 2025

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:stable - failure labels Mar 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPD-49581 Migrate remaining LocalFile.FrontendDataSetFilters to PW #4778

LPD-49581 Migrate remaining LocalFile.FrontendDataSetFilters to PW #4778

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

Base Branch:

Upstream Comparison:

18 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Mar 5, 2025

thektan commented Mar 6, 2025

liferay-continuous-integration commented Mar 6, 2025

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 6, 2025

thektan commented Mar 6, 2025

LPD-49581 Migrate remaining LocalFile.FrontendDataSetFilters to PW #4778

Are you sure you want to change the base?

LPD-49581 Migrate remaining LocalFile.FrontendDataSetFilters to PW #4778

Conversation

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 13 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

❌ ci:test:frontend - 0 out of 1 jobs passed in 7 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

Test bundle downloads:

thektan commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

liferay-continuous-integration commented Mar 5, 2025

❌ ci:test:frontend - 33 out of 51 jobs passed in 2 hours

Base Branch:

Upstream Comparison:

18 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Mar 5, 2025

thektan commented Mar 6, 2025

liferay-continuous-integration commented Mar 6, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 6, 2025

thektan commented Mar 6, 2025