-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-50348 Activating or deactivating a System Data Set causes no effect #4779
base: master
Are you sure you want to change the base?
Conversation
CI is automatically triggering the following test suites:
|
ci:test:frontend |
❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50348 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ⚙️ Running preflight checks... [exec] [exec] ⚙️ Checking outdated tsconfig.json files ... [exec] [exec] ⚙️ Running TypeScript checks on modified files... [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers [exec] ✅ Checked apps/frontend-data-set/frontend-data-set-web [exec] ✅ Checked apps/frontend-data-set/frontend-data-set-sample-web [exec] [exec] ⚙️ Running format checks on modified files... [exec] Done in 15.85s. [exec] [exec] > Task :portalYarnCheckFormat [exec] Gradle build finished at 2025-03-05 21:09:42.184. [exec] [exec] BUILD SUCCESSFUL in 28s [exec] 3 actionable tasks: 3 executed [exec] [exec] [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-13-09-17.html [exec] A fine-grained performance profile is available: use the --scan option. [beanshell] Executing Gradle task: packageRunCheckFormat [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation. [exec] Daemon will be stopped at the end of the build [exec] > Task :downloadNode [exec] [exec] > Task :npmInstall [exec] npm WARN config production Use `--omit=dev` instead. [exec] [exec] added 130 packages, and audited 134 packages in 1s [exec] [exec] 23 packages are looking for funding [exec] run `npm fund` for details [exec] [exec] found 0 vulnerabilities [exec] [exec] > Task :packageRunCheckFormat [exec] npm WARN config production Use `--omit=dev` instead. [exec] [exec] > @liferay/[email protected] checkFormat [exec] > tsc [exec] [exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'. [exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'. [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'. |
Jenkins Build:test-portal-source-format#6261 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#24627 |
rebased |
ci:test:sf |
ci:test:frontend |
❌ ci:test:sf - 0 out of 1 jobs passed in 8 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50348 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ?????? Running preflight checks... [exec] [exec] ?????? Checking outdated tsconfig.json files ... [exec] [exec] ?????? Running TypeScript checks on modified files... [exec] ?????? A total of 8 CPUs were detected: launching tsc using 8 workers [exec] ??? Checked apps/frontend-data-set/frontend-data-set-web [exec] ??? Checked apps/frontend-data-set/frontend-data-set-sample-web [exec] [exec] ?????? Running format checks on modified files... [exec] Done in 23.49s. [exec] [exec] > Task :portalYarnCheckFormat [exec] Gradle build finished at 2025-03-05 22:21:48.347. [exec] [exec] BUILD SUCCESSFUL in 36s [exec] 3 actionable tasks: 3 executed [exec] [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-14-21-16.html [exec] A fine-grained performance profile is available: use the --scan option. [exec] [beanshell] Executing Gradle task: packageRunCheckFormat [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation. [exec] Daemon will be stopped at the end of the build [exec] > Task :downloadNode [exec] [exec] > Task :npmInstall [exec] npm WARN config production Use `--omit=dev` instead. [exec] [exec] added 130 packages, and audited 134 packages in 3s [exec] [exec] 23 packages are looking for funding [exec] run `npm fund` for details [exec] [exec] found 0 vulnerabilities [exec] [exec] > Task :packageRunCheckFormat [exec] npm WARN config production Use `--omit=dev` instead. [exec] [exec] > @liferay/[email protected] checkFormat [exec] > tsc [exec] [exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'. [exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'. [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'. |
Jenkins Build:test-portal-source-format#6319 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#7101 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#11946 Jenkins Report:jenkins-report.html Jenkins Suite:frontend Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#24630 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#14022 Jenkins Report:jenkins-report.html Jenkins Suite:frontend Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#30479 |
✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50348 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#7033 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#27587 |
✔️ ci:test:stable - 24 out of 24 jobs passed❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 47 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:ci:test:relevant - 30 out of 32 jobs PASSED2 Failed Jobs:
30 Successful Jobs:For more details click here.Failures unique to this pull:For upstream results, click here.Test bundle downloads: |
✔️ ci:test:stable - 32 out of 32 jobs passed in 1 hour 52 minutesClick here for more details.Base Branch:Branch Name: master ci:test:stable - 32 out of 32 jobs PASSED32 Successful Jobs:
For more details click here.Test bundle downloads: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#14024 Jenkins Report:jenkins-report.html Jenkins Suite:stable Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#30485 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6620 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#13598 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#12793 Jenkins Report:jenkins-report.html Jenkins Suite:frontend Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#27957 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#11095 Jenkins Report:jenkins-report.html Jenkins Suite:frontend Pull Request:liferay-frontend#4779 Testray Routine:EE Pull Request Testray Build ID: Testray Importer:publish-testray-report#24526 |
References:
In this PR, we are fixing one bug and enhancing some other stuff related to such bug:
active
data setsClassicSystemFDSEntry
not being a "real" system data set. This required:groupId
FDSRendererImpl
so that properties coming from tag lib are kept when custom/system serializers provide no data for the propcustomized
sample toadvanced
to better describe its purpose and avoid misunderstanding with the newer concept of "Custom Data Sets"<react:component>
tag is not using theFDSRenderer
/FDSSerializer
subsystemcustom internal view
sample, which allows to fix https://liferay.atlassian.net/browse/LPD-44560 because we can sample such external view via props transformerpropsTransformer
support for custom data sets at the persistence level. This means: