Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-50348 Activating or deactivating a System Data Set causes no effect #4779

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dsanz
Copy link
Collaborator

@dsanz dsanz commented Mar 5, 2025

References:

In this PR, we are fixing one bug and enhancing some other stuff related to such bug:

  • Fixing https://liferay.atlassian.net/browse/LPD-50348 by ensuring CustomFDSSerializer is available only for active data sets
  • Fixing ClassicSystemFDSEntry not being a "real" system data set. This required:
    • Providing proper REST information for a "classic" system data set, pointing to the general-purpose jaxrs app associated to the proper data provider and interpolating the right groupId
    • Allowing FDS to render a creation menu even if returned data does not contain collection-level actions. This entails classic-display instances to define a creation menu (our sample seems to be the first case)
  • Improving FDSRendererImpl so that properties coming from tag lib are kept when custom/system serializers provide no data for the prop
  • As a bonus (Brian asked for this) I'm renaming the customized sample to advanced to better describe its purpose and avoid misunderstanding with the newer concept of "Custom Data Sets"
  • As a second bonus, I'm leveraging this PR to rename "React" system data sets because:
    • It does not make any sense to define a system/custom data set for a react usage of FDS because <react:component> tag is not using the FDSRenderer/FDSSerializer subsystem
    • So I'm defining a new system data set targeted at custom internal view sample, which allows to fix https://liferay.atlassian.net/browse/LPD-44560 because we can sample such external view via props transformer
  • As a third bonus, I'm adding propsTransformer support for custom data sets at the persistence level. This means:
    • Adding an optional field to the data model
    • Enabling import of such new field when creating an editable copy of a system data set
    • Enabling custom data set serialization of such value
  • Finally, I'm fixing a couple of failing tests. One being a bug in creationMenu dropdown item boolean property being serialized as string, the other fixes test itself

@dsanz dsanz requested a review from liferay-frontend as a code owner March 5, 2025 20:50
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@dsanz
Copy link
Collaborator Author

dsanz commented Mar 5, 2025

ci:test:frontend

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Sender Branch:

Branch Name: LPD-50348
Branch GIT ID: 9acb750c12a286ed87e6efd34c2915f60d23b142

0 out of 1jobs PASSED
For more details click here.
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] ✅ Checked apps/frontend-data-set/frontend-data-set-web
     [exec] ✅ Checked apps/frontend-data-set/frontend-data-set-sample-web
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec] Done in 15.85s.
     [exec] 
     [exec] > Task :portalYarnCheckFormat
     [exec] Gradle build finished at 2025-03-05 21:09:42.184.
     [exec] 
     [exec] BUILD SUCCESSFUL in 28s
     [exec] 3 actionable tasks: 3 executed
     [exec] 
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-13-09-17.html
     [exec] A fine-grained performance profile is available: use the --scan option.
[beanshell] Executing Gradle task: packageRunCheckFormat
     [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
     [exec] Daemon will be stopped at the end of the build 
     [exec] > Task :downloadNode
     [exec] 
     [exec] > Task :npmInstall
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] added 130 packages, and audited 134 packages in 1s
     [exec] 
     [exec] 23 packages are looking for funding
     [exec]   run `npm fund` for details
     [exec] 
     [exec] found 0 vulnerabilities
     [exec] 
     [exec] > Task :packageRunCheckFormat
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] > @liferay/[email protected] checkFormat
     [exec] > tsc
     [exec] 
     [exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:157295730

@dsanz
Copy link
Collaborator Author

dsanz commented Mar 5, 2025

rebased

@dsanz
Copy link
Collaborator Author

dsanz commented Mar 5, 2025

ci:test:sf

@dsanz
Copy link
Collaborator Author

dsanz commented Mar 5, 2025

ci:test:frontend

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Sender Branch:

Branch Name: LPD-50348
Branch GIT ID: b6889d75d35ccb9e4a54df54d03ece4d508a5ba3

0 out of 1jobs PASSED
For more details click here.
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ?????? Running preflight checks...
     [exec] 
     [exec] ?????? Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ?????? Running TypeScript checks on modified files...
     [exec] ?????? A total of 8 CPUs were detected: launching tsc using 8 workers
     [exec] ??? Checked apps/frontend-data-set/frontend-data-set-web
     [exec] ??? Checked apps/frontend-data-set/frontend-data-set-sample-web
     [exec] 
     [exec] ?????? Running format checks on modified files...
     [exec] Done in 23.49s.
     [exec] 
     [exec] > Task :portalYarnCheckFormat
     [exec] Gradle build finished at 2025-03-05 22:21:48.347.
     [exec] 
     [exec] BUILD SUCCESSFUL in 36s
     [exec] 3 actionable tasks: 3 executed
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-14-21-16.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] 
[beanshell] Executing Gradle task: packageRunCheckFormat
     [exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
     [exec] Daemon will be stopped at the end of the build 
     [exec] > Task :downloadNode
     [exec] 
     [exec] > Task :npmInstall
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] added 130 packages, and audited 134 packages in 3s
     [exec] 
     [exec] 23 packages are looking for funding
     [exec]   run `npm fund` for details
     [exec] 
     [exec] found 0 vulnerabilities
     [exec] 
     [exec] > Task :packageRunCheckFormat
     [exec] npm WARN config production Use `--omit=dev` instead.
     [exec] 
     [exec] > @liferay/[email protected] checkFormat
     [exec] > tsc
     [exec] 
     [exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'.
     [exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:157384792

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:frontend - 33 out of 52 jobs passed in 2 hours 4 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1387401_11946

Base Branch:

Branch Name: master
Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

Upstream Comparison:

Branch GIT ID: d6224e8cb32a191c5c0793f4ae7d1920018e8f6d
Jenkins Build URL: EE Development Acceptance (master) - 1212 - 2025-03-05[08:36:03]

ci:test:frontend - 33 out of 52 jobs PASSED

19 Failed Jobs:

33 Successful Jobs:
    For more details click here.

    Failures unique to this pull:

    1. ...
    Test bundle downloads:

    @liferay-continuous-integration
    Copy link
    Collaborator

    @liferay-continuous-integration
    Copy link
    Collaborator

    ❌ ci:test:frontend - 33 out of 52 jobs passed in 1 hour 11 minutes

    Click here for more details.

    This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

    ci:reevaluate:1277401_14022

    Base Branch:

    Branch Name: master
    Branch GIT ID: 05838d3744cde5c1501047bdced6e7e38cdfd620

    Upstream Comparison:

    Branch GIT ID: d6224e8cb32a191c5c0793f4ae7d1920018e8f6d
    Jenkins Build URL: EE Development Acceptance (master) - 1212 - 2025-03-05[08:36:03]

    ci:test:frontend - 33 out of 52 jobs PASSED

    19 Failed Jobs:

    33 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. ...
      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

      Sender Branch:

      Branch Name: LPD-50348
      Branch GIT ID: 24459241231efb8a953837efdcdf2dc15263cc31

      1 out of 1jobs PASSED
      1 Successful Jobs:
      For more details click here.

      @liferay-continuous-integration
      Copy link
      Collaborator

      Jenkins Report:jenkins-report.html
      Jenkins Suite:sf
      Testray Routine:EE Pull Request
      Testray Build ID:158069431

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 24 out of 24 jobs passed

      ❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 47 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

      Upstream Comparison:

      Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a
      Jenkins Build URL: EE Development Acceptance (master) - 1214 - 2025-03-05[16:35:47]

      ci:test:stable - 24 out of 24 jobs PASSED
      24 Successful Jobs:
        ci:test:relevant - 30 out of 32 jobs PASSED

        2 Failed Jobs:

        30 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          For upstream results, click here.

          Test bundle downloads:

          @liferay-continuous-integration
          Copy link
          Collaborator

          @liferay-continuous-integration
          Copy link
          Collaborator

          @liferay-continuous-integration
          Copy link
          Collaborator

          @liferay-continuous-integration
          Copy link
          Collaborator

          ❌ ci:test:frontend - 32 out of 52 jobs passed in 2 hours 36 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

          Upstream Comparison:

          Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a
          Jenkins Build URL: EE Development Acceptance (master) - 1214 - 2025-03-05[16:35:47]

          ci:test:frontend - 32 out of 52 jobs PASSED

          20 Failed Jobs:

          32 Successful Jobs:
            For more details click here.

            Failures unique to this pull:

            1. ...
            Test bundle downloads:

            @liferay-continuous-integration
            Copy link
            Collaborator

            @liferay-continuous-integration
            Copy link
            Collaborator

            ❌ ci:test:frontend - 33 out of 52 jobs passed in 3 hours 19 minutes

            Click here for more details.

            Base Branch:

            Branch Name: master
            Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

            Upstream Comparison:

            Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a
            Jenkins Build URL: EE Development Acceptance (master) - 1214 - 2025-03-05[16:35:47]

            ci:test:frontend - 33 out of 52 jobs PASSED

            19 Failed Jobs:

            33 Successful Jobs:
              For more details click here.

              Failures unique to this pull:

              1. ...
              Test bundle downloads:

              @liferay-continuous-integration
              Copy link
              Collaborator

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              4 participants