LPD-50587 - Adapt FrontendDataSet component in DSM and CX pages #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50587 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#7610 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4780 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - juanjofgliferay > liferay-frontend - PR#4780 - 2025-03-06[07:20:36] Testray Build ID:Testray Importer:publish-testray-report#27950 |
juanjofgliferay
commented
Mar 6, 2025
| @@ -1,4 +1,5 @@ | |||
| .management-bar-wrapper { | |||
| background-color: #fff; | |||
There was a problem hiding this comment.
Need to define a background color in the fds. I don't like it, because it forces the management bar to have this color. It could be an issue when customers use the data set with a different custom theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story / Task
LPD-50561 / LPD-50587
Goal
Concerns
@mediaqueries consider min-width of the viewport. Need to investigate support of `@container queries.