Fix handling of undef integer values. #158
Conversation
rellic/AST/IRToASTVisitor.cpp
Outdated
| result = ast.CreateAdjustedIntLit(val); | ||
| } | ||
| } else if (llvm::isa<llvm::UndefValue>(constant)) { | ||
| //NOTE(artem): |
There was a problem hiding this comment.
This is probably going to be a more general issue, of having to deal with undef vals. I'm going to wait for @surovic to implement a fix in a way that he sees fit, as he might want to factor out handling of undefs.
There was a problem hiding this comment.
I don't really have a plan for undef values yet. So for now, I guess this is a good enough fix. Added as issue #159
@artemdinaburg do you have an input that I could put to the issue?
There was a problem hiding this comment.
So I had to read the undefined value description a bit more.
An undef (if not frozen, which we have not run into yet) can take any value. This is not undefined behavior, but an undefined value.
My opinion is that:
- This is probably due to some anvill issue, and anvill should definitely have a pass to see if
undefleaks out to final bitcode. - We may have
undefas a legitimate source into rellic, if, say, the ISA specs for some instruction specify a register is in an undefined state, and then the register is used. - The current behavior (assume that an
undefpointer is NULL) is perfectly valid, since it can indeed be NULL. - For this specific PR, we should return a constant integer of 0 of the right bit width (not cast to a pointer, as this is an int value). I will see if I can make the change.
- From a correctness and "what does the user expect?" standpoint, I think we should pick a value (say, zero) and emit function call like:
int32_t rellic_undefined_value_int32() {
#pragma error "The input bitcode uses an undefined value. This may not be an error, but it probably is. Uncomment this pragma to achieve recompilable code.
return 0; // any value works here
}
...
int var0 = rellic_undefined_value_int32();
...
The user of the decompiled code can then figure out what they want to do about the undef, and static analysis tools should be trivially able to see that rellic_undefined_value_*() returns 0 (or 42 or whatever we pick).
Fix handling of
undefinteger valuesThis was the source of a segfault due to a failed cast.