changes to ssh_config.py to support a global ssh_config for users #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittner
reviewed
Jul 26, 2018
| @@ -743,6 +751,7 @@ def main(): | |||
| identities=parsed.get('identities', []), | |||
| additional_args=options.additional_args, | |||
| socket=options.socket, | |||
| config=options.config, | |||
There was a problem hiding this comment.
The indentation doesn't seem to be correct here. Try running flake8 over this file.
bittner
reviewed
Jul 26, 2018
| @@ -751,15 +760,17 @@ def main(): | |||
| sshfp=options.sshfp, | |||
| randomart=options.randomart, | |||
| additional_args=options.additional_args, | |||
| socket=options.socket | |||
| socket=options.socket, | |||
| config=options.config | |||
There was a problem hiding this comment.
Same as above: The indentation doesn't seem to be correct here. Try running flake8 over this file.
bittner
reviewed
Jul 26, 2018
| ) | ||
| elif len(args) == 3: | ||
| openssh_connect(args[0], args[1], args[2], | ||
| command=options.command, | ||
| sshfp=options.sshfp, | ||
| randomart=options.randomart, | ||
| additional_args=options.additional_args, | ||
| socket=options.socket | ||
| socket=options.socket, | ||
| config=options.config |
There was a problem hiding this comment.
Same as above: The indentation doesn't seem to be correct here. Try running flake8 over this file.
bittner
reviewed
Jul 26, 2018
| @@ -895,6 +906,7 @@ def main(): | |||
| identities=identities, | |||
| additional_args=options.additional_args, | |||
| socket=options.socket, | |||
| config=options.config, | |||
There was a problem hiding this comment.
Same as above: The indentation doesn't seem to be correct here. Try running flake8 over this file.
ntaken
added a commit
to ntaken/GateOne
that referenced
this pull request
Sep 25, 2020
changes to ssh_config.py to support a global ssh_config for users liftoff#660 liftoff#660 by edwins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will allow an operator of GateOne to designate a global ssh_config for all end users.