-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed TESS search_individual_ffi functionality #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like all of the related functions are gone. I just want to discuss if we should remove it or deprecate it so there is a record that it was removed when MAST removed the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple issues to be addressed. Namely, I think calling the module should result in an error, not just a warning. The original arguments should be retained so that the error/warning raised pertains to deprecation rather than arguments in standard use cases. Finally, a new test should exist to make sure everything fails the right way.
Thanks for the great feedback. I've modified how the function is deprecated and changed the test to make sure it is throwing the appropriate error. Let me know what you think @d-giles ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Astroquery has changed functionality and is no longer returning TESS individual ffi files, allowing you to get ffi file list for a given sector, or allowing you to download them. This PR removes the TESSSearch.search_sector_ffis() functionality/tests/tutorials since this behaviour is no longer supported.