Updated catalogsearch to ignore cases of input catalogs, and added a way to avoid checking the cached file size
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerapritchard this now includes a test! |
|
I've temporarily removed the configuration parameter test since I was able to verify that the parameter is working for me locally, but the test was failing both locally and on github actions. We should revisit but I want to get this merged since its functional. |
christinahedges
changed the title
catalogsearch to ignore cases of input catalogscatalogsearch to ignore cases of input catalogs, and added a way to avoid checking the cached file size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #34 I added a config parameter
CHECK_CACHED_FILE_SIZEwhich, when set to False, will not search for the data using astroquery if the file already exists. This is set to True by default, but can be set to False to enable impatient users to speed up the return of their cached data.Fixes #34
I also (completely accidentally) included a minor change to
catalogsearch. This was supposed to be its own pull request and I message up. I frequently use"KIC"or"TIC"for input catalogs as they are usually capitalized, so I updated the codebase forcatalogsearchto use "lower" so that we aren't sensitive to cases.