Docs improvements for channel #2104
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 90.33% 90.34%
=======================================
Files 106 106
Lines 55732 55732
Branches 55732 55732
=======================================
+ Hits 50347 50350 +3
+ Misses 5385 5382 -3
☔ View full report in Codecov by Sentry. |
|
I believe this will have little impact and won't change things too much based on what I'm currently fixing up with #2077. So we don't need to consider it blocked. |
|
At least not that PR specifically. |
lightning/src/ln/channel.rs
Outdated
| /// Guaranteed to be Some after both ChannelReady messages have been exchanged (and, thus, | ||
| /// is_usable() returns true). | ||
| /// Guaranteed to be [`Some`] after both [`ChannelState::ChannelReady`] messages have been exchanged | ||
| /// (and, thus, [`is_usable()`] returns true). | ||
| /// Allowed in any state (including after shutdown) | ||
| /// | ||
| /// [`is_usable()`]: Self::is_usable | ||
| pub fn get_short_channel_id(&self) -> Option<u64> { |
There was a problem hiding this comment.
Ah wait. My bad. This will end up changing. Will let you know once I've unblocked you.
There was a problem hiding this comment.
@dunxen This should be unblocked now, no?
|
This should be un-draft-able now. Any desire to pick it back up @douglaz? |
Done. No clue if the comments are still valid though. |
douglaz
force-pushed
the
docs_fixes_channel
branch
from
10a7228 to
a15d0b5
Compare
|
Done rebasing |
See #2100 (comment)
It's blocked on #2077