[Splicing] Partial, handle splice_init & splice_ack messages #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Nov 13, 2024
optout21
force-pushed
the
splice-init
branch
from
3a3ff71 to
b85a9d7
Compare
6 tasks
optout21
commented
Nov 14, 2024
optout21
force-pushed
the
splice-init
branch
from
6ac5f01 to
e274887
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 88.32% 88.30% -0.03%
==========================================
Files 149 149
Lines 112912 112922 +10
Branches 112912 112922 +10
==========================================
- Hits 99731 99717 -14
- Misses 10694 10717 +23
- Partials 2487 2488 +1 ☔ View full report in Codecov by Sentry. |
optout21
changed the title
optout21
force-pushed
the
splice-init
branch
2 times, most recently
from
19f8ab8 to
4ee3735
Compare
jkczyz
reviewed
Nov 19, 2024
optout21
force-pushed
the
splice-init
branch
from
fd61390 to
6ee1aee
Compare
jkczyz
reviewed
Nov 19, 2024
|
I have reorganized code, moved most single-channel checks and handling logic into |
optout21
force-pushed
the
splice-init
branch
from
bb3b4de to
8e5e331
Compare
jkczyz
reviewed
Nov 20, 2024
optout21
force-pushed
the
splice-init
branch
from
9bbdf58 to
b1ba24b
Compare
|
Rebased (post #3137) and squashed |
jkczyz
reviewed
Nov 22, 2024
optout21
force-pushed
the
splice-init
branch
from
fb4968c to
9ffe4b1
Compare
jkczyz
reviewed
Nov 27, 2024
optout21
changed the title
|
Rebased and squashed |
optout21
changed the title
|
Rebased (minor merge conflict) |
|
Rebased (post Inbound/OutboundV2Channel merge #3498 ) |
wpaulino
reviewed
Jan 13, 2025
…splice_ack messages, but fail afterwards
|
I've closed the remaining two outstanding review comments. Note that this now depends/includes #3558 (I'll take care if merge is needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
splice_init&splice_ackmessages, without performing splicing.splice_initdoes not error, butsplice_ackreturns an error (and neither side continues with splicing).One next piece for splicing #3298 .
This can come before #3137 .