PoC: Use tweaked NUMS key for non-spendable Taproot script leaves #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change. tapd nodes v0.5 and older will fail to validate new group key V1 assets. |
Pull Request Test Coverage Report for Build 12773308187Details
💛 - Coveralls |
ffranr
force-pushed
the
nums-non-spend-leaves
branch
from
af75235 to
f6a7f79
Compare
ffranr
changed the title
ffranr
force-pushed
the
nums-non-spend-leaves
branch
2 times, most recently
from
d09b5bf to
a8ddd78
Compare
Introduced a `newVerboseBatch` function to create a verbose mint batch from a regular mint batch. This functionality is extracted from the existing list batch logic as part of a refactor. The function will be used in a future commit to include a verbose batch in the response of the FundBatch RPC endpoint.
Added comments to the planter function `buildGroupReqs` to improve code readability and explain the logic more clearly.
Introduce a guide outlining the workflow for using external group keys. Future commits in this PR will add features and implement changes to support the described workflow.
The FundBatch RPC endpoint now returns a verbose batch instead of a regular batch. The verbose batch includes additional asset group information required by external signers.
Added a new `ExternalKey` message type to represent an external key used for deriving and managing HD wallet addresses per BIP-86. A new field of type `ExternalKey` was added to the `MintAsset` message, enabling the specification of an external key when a mint request is added to the batch.
Introduce a new `ExternalKey` type and add external key fields of this type to `Seedling` and `GroupKeyRequest`.
Add unmarshalling support for the new `Asset.ExternalGroupKey` field in the `MintAsset` RPC endpoint.
Add an `external_key` field to the `GroupKeyRequest` RPC message, which will also make it available in the `UnsealedAsset` RPC message. Include marshalling functionality for the new field.
Added the following command line minting flags: - group_key_xpub - group_key_derivation_path - group_key_fingerprint
Updated the documentation for the `MintAsset.group_tapscript_root` field to clarify its purpose: it now represents the custom tapscript subtree root for V1 group key reveals and serves as the tapscript tree root for V0 group key reveals.
Add the `CustomTapscriptRoot` field to both the `GroupKey` and `GroupKeyRequest` types. This field stores the user-defined custom tapscript subtree root, which is committed to by the asset group key. Update the `buildGroupReqs` function to leverage this new field when constructing group key requests for generating asset group keys.
Introduce a new `GroupKeyVersion` type to represent the group key version in `asset.GroupKey` and `asset.GroupKeyRequest`. Add a `version` field to both `asset.GroupKey` and `asset.GroupKeyRequest`, with logic to populate it. Enhance the verification process by adding version-specific checks.
Update `GroupKeyRequest` methods to support the generation of version 1 (V1) group keys.
Add a new PSBT field to the `UnsealedAssets` RPC message type, which contains the byte-serialized PSBT equivalent of the group virtual transaction for unsealed assets. As a result, the `FundBatch` and `ListBatches` RPC endpoints now return group virtual PSBTs. Include logic to generate the group virtual PSBT. The PSBT is unsigned and is provided to allow signing with an external cold private key.
Extended the `asset_groups` database table with two new columns: `rows_version` and `custom_subtree_root`. These fields are required to store and retrieve new GroupKey data for use during mint proof generation, where the group key reveal is formulated.
Ensured the `version` and `custom_subtree_root` columns are populated with the appropriate GroupKey data when storing a group key in the database.
Implemented parsing logic for the `version` and `custom_subtree_root` fields when reading from the database.
Added support for group key reveal V1 alongside the existing group key reveal V0 when generating mint proofs.
Adds a test to ensure the new PSBT field introduced in the previous commit can be used to derive a transaction identical to the group virtual transaction.
Update the `build-itest` Makefile target, used as a subcommand during `make itest`, to ensure `chantools` is properly set up for integration tests. Additionally, update `.gitignore` to exclude the `chantools` build directory.
Add a test harness to execute the chantools binary via the command line and parse its output.
Added a new integration test, `testMintExternalGroupKeyChantools`, to verify the ability to mint an asset and generate an asset group signature using chantools with an externally managed signing key.
ffranr
force-pushed
the
cold-group-key
branch
from
c0c6795 to
5299e8b
Compare
This Proof-of-Concept demonstrates the NUMS-tweak formulation for hardware wallet testing. The NewNonSpendableScriptLeaf function now generates non-spendable Taproot leaves using a deterministic NUMS (Nothing-Up-My-Sleeve) key, tweaked with arbitrary data. This replaces the previous raw OP_RETURN approach with a `pk(data)` Miniscript script (`<pubkey> OP_CHECKSIG`), improving compatibility with current hardware wallets.
ffranr
force-pushed
the
nums-non-spend-leaves
branch
from
a8ddd78 to
f277228
Compare
ffranr
force-pushed
the
cold-group-key
branch
4 times, most recently
from
b801f9f to
5ca4168
Compare
|
I agree that this mathematically is correct as well. But let's go with #1290 instead, as that's a bit more formal and introduces code that we might be able to use in another context in the future. |
|
Close in favour of #1290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as a PoC which we should be able to use to test hardware wallets. This PR does not include all necessary doc updates.
This PR updates the
NewNonSpendableScriptLeaffunction to use a deterministic tweaked NUMS (Nothing-Up-My-Sleeve) key for generating non-spendable Taproot leaves. The previousOP_RETURN-based approach is replaced with apk(data)Miniscript script (<pubkey> OP_CHECKSIG), ensuring broader compatibility with modern hardware wallets.Notes for Reviewers