Aggregate Universe Stats: always store result of querySyncStats #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12904863504Details
💛 - Coveralls |
GeorgeTsagk
force-pushed
the
sync-stats-cache-fix
branch
from
5b63f13 to
f73aa87
Compare
guggero
reviewed
Jan 20, 2025
Our universe stats could run into a case where if in an un-cached state the db query takes longer than the default client timeout (usually 30s) then we'd fail the query and return early. This would cause the next client to also receive an error instead of the cached result, making this codepath stuck in an endless failing query. With this change we parallelize the db query and we always wait for the result in order to store it in cache. We may fail the function earlier, but the result will always be retrieved & persisted.
GeorgeTsagk
force-pushed
the
sync-stats-cache-fix
branch
from
f73aa87 to
c7f16f6
Compare
With this commit we add a simple test for the asynchronous cache population that was introduced previously. We make a single RPC call to the aggregate stats endpoint with a client timeout that is too small. This leads to an RPC failure, so we check whether the cache was updated in the background.
GeorgeTsagk
force-pushed
the
sync-stats-cache-fix
branch
from
c7f16f6 to
5aeb9f5
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Aggregate Universe Stats: always store result of querySyncStats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our universe stats could run into a case where if in an un-cached state (like on system start-up) the db query takes longer than the default client timeout (usually 30s) then we'd fail the query and return early. This would cause the next client to also receive an error instead of the cached result, making this codepath stuck in an endless failing query. With this change we parallelize the db query and we always wait for the result in order to store it in cache. We may fail the function earlier, but the result will always be retrieved & persisted. This way, even if the 1st client retrieves an error, the next one will receive the cached (late) result of the previous run.
Closes #1304