Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapchannel: detect asset related custom records correctly #1330

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

guggero
Copy link
Member

@guggero guggero commented Jan 27, 2025

Fixes more occurrences related to #1321.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12996726287

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 40.736%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapchannel/commitment.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapgarden/planter.go 2 64.98%
tapgarden/caretaker.go 4 68.11%
universe/interface.go 5 50.65%
Totals Coverage Status
Change from base Build 12992630782: 0.02%
Covered Lines: 26767
Relevant Lines: 65709

💛 - Coveralls

@gijswijs gijswijs self-requested a review January 27, 2025 20:42
Copy link
Contributor

@gijswijs gijswijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

I've checked the repo with the following regex \.CustomRecords.*\d and couldn't find any other occurences apart from this one:

require.Len(t.t, encodeResp.CustomRecords, 1)
var rfqIdType rfqmsg.HtlcRfqIDType
rfqIdTlvTypeNumber := uint64(rfqIdType.TypeVal())
require.Len(t.t, encodeResp.CustomRecords[rfqIdTlvTypeNumber], 32)

That one already checks on the custom record type, so that won't be a problem.

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roasbeef Roasbeef merged commit 5558b41 into main Jan 28, 2025
18 checks passed
@Roasbeef Roasbeef added this to the v0.5.1 milestone Jan 28, 2025
@guggero guggero deleted the asset-htlc-detection branch January 28, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants