Add loadtest sendV2
#1331
Open
Add loadtest sendV2
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
4054555 to
fd3390e
Compare
Pull Request Test Coverage Report for Build 13154191047Details
💛 - Coveralls |
ffranr
reviewed
Jan 30, 2025
This commit adds a refactored version of the send test, which uses less assertions and rpc calls. This is meant to speed things up compared to the old test, plus offer some more coverage by utilizing normal assets and balances greater than 1 (case for collectibles).
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
fd3390e to
84cb596
Compare
|
Rebased on |
guggero
reviewed
Feb 5, 2025
|
|
||
| // Let's make sure Bob is aware of all the assets that Alice may have | ||
| // minted. | ||
| itest.SyncUniverses(ctx, t, bob, alice, uniHost, cfg.TestTimeout) |
There was a problem hiding this comment.
I think we probably have to add a new parameter to this function that allows us to sync transfer proofs as well.
When I ran this test a second time after running 1 mintV2 and 1 sendV2 test, this sync never completed, because it only tried syncing issuance proofs.
|
|
||
| // Alice is set to be the minter in mintV2, so we use Alice's universe. | ||
| var ( | ||
| uniHost = fmt.Sprintf( |
There was a problem hiding this comment.
nit: if just uniHost := fmt.Sprintf(...) then can fit on one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1285
This PR adds the last 2 commits.
Description
This PR adds a new refactored send test for our loadtest suite, `sendV2.
The new send test uses normal assets which may have balances greater than
1(case for collectibles), which offers a bit more coverage for our code (coin selection, psbt signing, etc).Compared to the original send test, we strip away any non-mandatory assertions and RPC calls, keeping them to the minimum required to make things happen.