Allow selecting coins in `sendcoins` #8955

yyforyongyu · 2024-07-30T09:35:33Z

Replaces #8516, fixes #6949

coderabbitai · 2024-07-30T09:35:37Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hieblmi

Thanks for picking this up @yyforyongyu! I've checked out the test cases you added and left a suggestion. Since the original commits did not change and were already approved I will only aim for a tAck in my next review round.

cmd/lncli/cmd_open_channel.go

hieblmi · 2024-08-05T08:38:55Z

itest/lnd_misc_test.go

+
+	// Since the first two UTXOs have been sent to an address outside her
+	// wallet, Alice should see a single UTXO now.
+	ht.AssertNumUTXOs(alice, 1)


Could we further check that the remaining coin can't be selected and spent in its entirety so that the required reserves are not violated?

On this note, should the API allow to spend the coin up until the required reserve and not return an error unless other constraints like the dust limit of the sending amount are reached? Maybe further tests can document behavior here as well.

yeah I like it, added a test to show how it behaves atm.

guggero

Not too far off I think, mainly some code style changes on the wish list.

rpcserver.go

guggero · 2024-08-05T12:58:56Z

sweep/walletsweep.go

@@ -260,6 +267,15 @@ func CraftSweepAllTx(feeRate, maxFeeRate chainfee.SatPerKWeight,

 		log.Trace("[WithCoinSelectLock] finished fetching UTXOs")

+		// Use select utxos, if provided.
+		if len(selectUtxos) > 0 {
+			utxos, err = fetchUtxosFromOutpoints(utxos,


nit: formatting.

sweep/walletsweep.go

hieblmi

Thanks for the additional itest that documents the utxo selection and channel reserves.

I've tested multiple scenarios in regtest that I also confirmed in the first version of this PR, tACK ✅

EDIT: The test failures seem unrelated to this PR.

hieblmi · 2024-08-06T17:17:15Z

itest/lnd_misc_test.go

+// also checks that change outputs will be created automatically if `SendAll`
+// flag is set.
+func testSendSelectedCoinsChannelReserve(ht *lntest.HarnessTest) {
+	chanAmt := btcutil.Amount(100000)


nit: 100_000

hieblmi · 2024-08-06T18:01:49Z

itest/lnd_misc_test.go

+	tx := ht.GetNumTxsFromMempool(1)[0]
+
+	// Assert the tx has the expected shape. It should have 2 inputs and 2
+	// output.


nit: outputs

guggero

Nice, LGTM 🎉

Signed-off-by: Ononiwu Maureen <[email protected]>

This commit updates the interface methods from `lnwallet.WalletController` to take optional input set which can be used to create the tx.

Signed-off-by: Ononiwu Maureen <[email protected]>

Also rename the send all coins test for clarity.

yyforyongyu added rpc Related to the RPC interface utxo sweeping labels Jul 30, 2024

yyforyongyu added this to the v0.18.3 milestone Jul 30, 2024

yyforyongyu requested review from guggero and hieblmi July 30, 2024 09:35

saubyk assigned yyforyongyu Aug 1, 2024

hieblmi reviewed Aug 5, 2024

View reviewed changes

guggero mentioned this pull request Aug 5, 2024

Simplify coin selection for sendcoins #8516

Closed

8 tasks

guggero reviewed Aug 5, 2024

View reviewed changes

yyforyongyu force-pushed the cr-8516-240729-sendcoins branch 2 times, most recently from 6ccb920 to 0cb2739 Compare August 6, 2024 08:00

yyforyongyu requested review from guggero and hieblmi August 6, 2024 11:55

hieblmi approved these changes Aug 6, 2024

View reviewed changes

guggero approved these changes Aug 7, 2024

View reviewed changes

Chinwendu20 and others added 9 commits August 7, 2024 20:42

lnrpc: Add Outpoint field in SendCoinsRequest

468ca87

Signed-off-by: Ononiwu Maureen <[email protected]>

multi: expand SendOutputs and CreateSimpleTx to take utxos

99339f7

This commit updates the interface methods from `lnwallet.WalletController` to take optional input set which can be used to create the tx.

sweep: Add selectUtxos to CraftSweepAllTx args

13bad2c

lnd: modify sendcoin rpc impl for select utxos

b50a1e6

Signed-off-by: Ononiwu Maureen <[email protected]>

cmd: Export and move utxosToOutpoint.

900d7fd

Signed-off-by: Ononiwu Maureen <[email protected]>

lncli: Add outpoints flag to sendcoins command

0184846

Signed-off-by: Ononiwu Maureen <[email protected]>

itest+lntest: return the error from SendCoinsAssertErr

0041426

Also rename the send all coins test for clarity.

itest: add testSendSelectedCoins to check selected utxos

e542351

docs: update release notes

dcd8269

yyforyongyu force-pushed the cr-8516-240729-sendcoins branch from 0cb2739 to dcd8269 Compare August 7, 2024 12:43

guggero merged commit d776174 into lightningnetwork:master Aug 7, 2024
25 of 27 checks passed

yyforyongyu deleted the cr-8516-240729-sendcoins branch August 7, 2024 15:02

kaloudis mentioned this pull request Aug 7, 2024

LND: ability to use full UTXO during channel open or on-chain payment ZeusLN/zeus#790

Closed

starius mentioned this pull request Sep 19, 2024

sweep, rpcserver: optimize SendAll cost wise #8936

Closed

6 tasks

kaloudis mentioned this pull request Sep 21, 2024

[feature]: External Accounts: Coin Control: add ability to spend a full UTXO #9130

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow selecting coins in `sendcoins` #8955

Allow selecting coins in `sendcoins` #8955

yyforyongyu commented Jul 30, 2024

coderabbitai bot commented Jul 30, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

hieblmi left a comment

hieblmi Aug 5, 2024

yyforyongyu Aug 6, 2024

guggero left a comment

guggero Aug 5, 2024

yyforyongyu Aug 6, 2024

hieblmi left a comment •

edited

Loading

hieblmi Aug 6, 2024

yyforyongyu Aug 7, 2024

hieblmi Aug 6, 2024

yyforyongyu Aug 7, 2024

guggero left a comment

Allow selecting coins in sendcoins #8955

Allow selecting coins in sendcoins #8955

Conversation

yyforyongyu commented Jul 30, 2024

coderabbitai bot commented Jul 30, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

hieblmi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guggero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hieblmi left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guggero left a comment

Choose a reason for hiding this comment

Allow selecting coins in `sendcoins` #8955

Allow selecting coins in `sendcoins` #8955

CodeRabbit Configuration File (`.coderabbit.yaml`)

hieblmi left a comment •

edited

Loading