Update lib.rs #247
Open
Update lib.rs #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have simplified the code by combining functions that appear to be performed the same task. For example, the create_whoami and inner_create_whoami functions both perform the same task of creating a new profile and linking it to the "agents" path and the agent's pubkey. These two functions have now been combined into one function to reduce redundancy. Additionally, the use of the get_peers function in both create_whoami and inner_create_whoami have been refactored to a single function that is called by both, rather than duplicating the function call. The create_imported_profile function also performs similar tasks to the other two functions, so I have taken a chance and combined it with them as well. Haven't tested yet but should work.. give it a try.
|
Hi @adamth0mps0n I can see why this might be an improvement, but it also appears that some of the other necessary functions like fetch_agents have been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have simplified the code by combining functions that appear to be performed the same task.
For example, the create_whoami and inner_create_whoami functions both perform the same task of creating a new profile and linking it to the "agents" path and the agent's pubkey. These two functions have now been combined into one function to reduce redundancy.
Additionally, the use of the get_peers function in both create_whoami and inner_create_whoami have been refactored to a single function that is called by both, rather than duplicating the function call.
The create_imported_profile function also performs similar tasks to the other two functions, so I have taken a chance and combined it with them as well. Haven't tested yet but should work.. give it a try.